From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF340FF886F for ; Thu, 30 Apr 2026 09:47:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 79B0284467; Thu, 30 Apr 2026 09:47:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id wvMMt04NPzez; Thu, 30 Apr 2026 09:47:00 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0FECA84464 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777542416; bh=3iUAXAMhvXecm+oHVms/+wGjpA7ssvDLru0iFsh2l+U=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=WZ2iWEbDPS0G6V3ISku4/S9/2fcdcYtzk8/3G19ozzrphHQU8NA0C/f+5Yud5toFm AnGg+ltC/FmnZHCy/y6l6zJI9rgb6ssJ+uHqqQUyRQ6MNkK0j3TWaz4rT5z0sc/SdB toz9XvcCm90viVS9OnuNK/IW38bFlPqv7YwDE81htBG2WffYsk5iN4QmXd06vssGcX mwaQgGmudqeGRhZ5DlajMZz/gePweiUdjnQKkJMGUthaSaDuFTHdjL58D/ISmjbmGg n09nlZPlWOpWLQfN57V0svTQGjhottLDW/+0ux1dPoWXpJ01zzr/+jnt7MDQydwwBj OAXdRhOhHNnhg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 0FECA84464; Thu, 30 Apr 2026 09:46:56 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 4E8AF18F for ; Thu, 30 Apr 2026 09:46:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 34B6442782 for ; Thu, 30 Apr 2026 09:46:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AQx0Bk4T7Wsy for ; Thu, 30 Apr 2026 09:46:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12; helo=mgamail.intel.com; envelope-from=grzegorz.nitka@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org DB02D42781 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DB02D42781 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by smtp4.osuosl.org (Postfix) with ESMTPS id DB02D42781 for ; Thu, 30 Apr 2026 09:46:52 +0000 (UTC) X-CSE-ConnectionGUID: Gao/FpaiS++zHDbjjrHWwA== X-CSE-MsgGUID: rIWpeuUjTzSi1tL+ZGtoFw== X-IronPort-AV: E=McAfee;i="6800,10657,11771"; a="82342590" X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="82342590" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2026 02:46:52 -0700 X-CSE-ConnectionGUID: 59Py9SOzQTWl3mG6rX/Zlg== X-CSE-MsgGUID: N9nGTysXSpSRPoxcZo0z1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="272649754" Received: from gklab-003-001.igk.intel.com ([10.91.173.48]) by orviesa001.jf.intel.com with ESMTP; 30 Apr 2026 02:46:47 -0700 From: Grzegorz Nitka To: netdev@vger.kernel.org Date: Thu, 30 Apr 2026 11:42:32 +0200 Message-Id: <20260430094238.987976-3-grzegorz.nitka@intel.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20260430094238.987976-1-grzegorz.nitka@intel.com> References: <20260430094238.987976-1-grzegorz.nitka@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777542413; x=1809078413; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/HBM1v6M04Z+Jc0mYsEibM5D9jaupGjKj8gDCUGJ9xY=; b=D/NggZxYybTb8cT3ktSaM93AEBCuHDT+ShglguWKK4+WfhSE2fR+uNKy 08VAgvCH1QG8pTMnQ8rcfiTyqHklpLo5itFdEugpFlFoIHfJqplFI+LLi JpmUbPzhHSACSZTDUY1VWAioGnFM+kG88Y+0iiqneEi/idB1+oXHm/NtN qj+QVHW7ScqLVCekZtinlwhwAZlFAcS6pWcYo9X89UDO5gfMRQ1/1NPby UufH2+Z9NdLkUmfoYpaSJ8LJ0G0WIKpuf83Ie9dwmb4vkBfl6yq8VTpx/ VqwhWJaKCsRMt/WslXCPwxS9oCNrEqajFXf6nuz0tTNPD4eBWHJ2FDR7F g==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=D/NggZxY Subject: [Intel-wired-lan] [PATCH v7 net-next 2/8] dpll: allow registering FW-identified pin with a different DPLL X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivecera@redhat.com, vadim.fedorenko@linux.dev, kuba@kernel.org, jiri@resnulli.us, edumazet@google.com, przemyslaw.kitszel@intel.com, richardcochran@gmail.com, donald.hunter@gmail.com, linux-kernel@vger.kernel.org, arkadiusz.kubalewski@intel.com, Aleksandr Loktionov , andrew+netdev@lunn.ch, intel-wired-lan@lists.osuosl.org, horms@kernel.org, Prathosh.Satish@microchip.com, anthony.l.nguyen@intel.com, pabeni@redhat.com, davem@davemloft.net, Jiri Pirko Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Relax the (module, clock_id) equality requirement when registering a pin identified by firmware (pin->fwnode). Some platforms associate a FW-described pin with a DPLL instance that differs from the pin's (module, clock_id) tuple. For such pins, permit registration without requiring the strict match. Non-FW pins still require equality. Reviewed-by: Jiri Pirko Reviewed-by: Arkadiusz Kubalewski Reviewed-by: Aleksandr Loktionov Signed-off-by: Grzegorz Nitka --- drivers/dpll/dpll_core.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index cbb635db4321..afe4552bdcd4 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -883,11 +883,21 @@ dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin, return -EINVAL; mutex_lock(&dpll_lock); - if (WARN_ON(!(dpll->module == pin->module && - dpll->clock_id == pin->clock_id))) + + /* + * For pins identified via firmware (pin->fwnode), allow registration + * even if the pin's (module, clock_id) differs from the target DPLL. + * For non-fwnode pins, require a strict (module, clock_id) match. + */ + if (!pin->fwnode && + WARN_ON_ONCE(dpll->module != pin->module || + dpll->clock_id != pin->clock_id)) { ret = -EINVAL; - else - ret = __dpll_pin_register(dpll, pin, ops, priv, NULL); + goto out_unlock; + } + + ret = __dpll_pin_register(dpll, pin, ops, priv, NULL); +out_unlock: mutex_unlock(&dpll_lock); return ret; -- 2.39.3