From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C40E5CD13DE for ; Fri, 1 May 2026 01:25:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 78CD741183; Fri, 1 May 2026 01:25:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WnawyuPk8UBS; Fri, 1 May 2026 01:25:15 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1ABA1411A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1777598715; bh=oVNJyuWqlMR4ml4qJTrmF4Dl7mhOJUtG2QO1Cc6843I=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=iNKbrwSpz1E39kptOJgZBQvotalh/oOPuWOoI5cEnu0gHm2Kr8tFxTeWSBjeaD/Fc 0SP+IdYTfMgVMleVt+rEz/+piPCx2rr1yzHiOiYoMmlPEGvuPvjrr06KjxWmHKZ1kf YPf9je3+fpWyyYldpYaHAkSPSWVvVBdbNLGLBxeZY9v5RXpQSFJ9rYuvunffUHdT1u uZqagG7eKf9DoevntoGHy0KsCzUf5Y5tUGe6blO8M35ZV5YH0RB5rxKRBBxAzXK6tF 8rCCgMSVRgYCUHiDFos7tTcanZKu7W+wLQnuhBNyNgQTFlUbuibMZXLhf0OJW41yro qC/DtLBY5mtiA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 1ABA1411A5; Fri, 1 May 2026 01:25:15 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 27A47127 for ; Fri, 1 May 2026 01:25:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1942083BB8 for ; Fri, 1 May 2026 01:25:13 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4WlY56wK5Skg for ; Fri, 1 May 2026 01:25:12 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1349; helo=mail-dy1-x1349.google.com; envelope-from=39gd0aqykdx86jjggdbjjbg9.7jhdio9g-rdm98-g5igdnon.jnpjng.jmb@flex--boolli.bounces.google.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 5E38F83AE6 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5E38F83AE6 Received: from mail-dy1-x1349.google.com (mail-dy1-x1349.google.com [IPv6:2607:f8b0:4864:20::1349]) by smtp1.osuosl.org (Postfix) with ESMTPS id 5E38F83AE6 for ; Fri, 1 May 2026 01:25:12 +0000 (UTC) Received: by mail-dy1-x1349.google.com with SMTP id 5a478bee46e88-2ba8013a9e3so2434212eec.0 for ; Thu, 30 Apr 2026 18:25:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777598711; x=1778203511; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oVNJyuWqlMR4ml4qJTrmF4Dl7mhOJUtG2QO1Cc6843I=; b=jH173uenUqw0oXiUApl3d9ERpRc+qH6jYlCqMcOu29VSlRRQy1OHp6SaEbio1/boRw 74GCguFeLIvAl0WDNjMe3cOUfI2ZG4gzgpEyIDg5/WYe2/xB86rFAdJFd6e3eXAOE+ZK CjQ49s04iSBI7lVkxsFANDt6YY2FRrom1mjyVc1vN5cO3muktf0KW0ZkKZkNAgqGR2ch da97HOhA1ivpsTKspixVYVNuia9j1CFU6k0LwTkO9GaNtpcFq6OkGgPxRsXkQS8v6VBK X6f0QdIO1XZpKHMPSSjyHOrgMuI6Lm5ILcMJU3wt1mHF0+3yYbF77AfugU+7CtjMTeiW 29Kw== X-Forwarded-Encrypted: i=1; AFNElJ/sq7oND1zGq40KsUkuroakT9AeYUbD3BBPs7NELo3vxWG4CEu4hT6F1Qi49TXlOkM4XoRcaVY+5XHzs4snUVs=@lists.osuosl.org X-Gm-Message-State: AOJu0Yzhp9qgt/TLwTidlVx6ITMhtIZB+BRdnhH48P9Urn2EMaC1bn7F Jeznmbt04L4wCD7Zcf8pigyCOP3xJHhuAbcl3pcP8LqPZI+1s/yyERsIRPPluu6uOvI5WwDvEX4 80frDiQ== X-Received: from dybvi26.prod.google.com ([2002:a05:7301:531a:b0:2d8:dd18:baee]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:6743:b0:2d9:bc8d:f62a with SMTP id 5a478bee46e88-2ed3e486c61mr2586087eec.16.1777598710661; Thu, 30 Apr 2026 18:25:10 -0700 (PDT) Date: Fri, 1 May 2026 01:25:07 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260501012507.461044-1-boolli@google.com> To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Type: text/plain; charset="UTF-8" X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777598711; x=1778203511; darn=lists.osuosl.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=oVNJyuWqlMR4ml4qJTrmF4Dl7mhOJUtG2QO1Cc6843I=; b=JHPXaRqqkdaXV272idJ4VNgEsTN/W2GomXKaXQCvAQg+w+IsJAIte3wcWR7GE03mU+ k5eWJtZnSdGtnwVRsyoMGSFrSa4OPH5YM0I8vZioU2ymWbfCRHYL5WYsU0QzlP3DJhPd REaOow/3YtW82H6HZuMjPr9fsf3qDRO/+dut8ZFnCCXTk89GN1AjjReZofYmXoFmQHjY yhHEEEsPMFjlIzurmlr3F3iA8tAcl8Inaa0K/qa0ZZUxR+tE0MhVmlX6OOhlJL37qYZE k0dK0j5Bfe4O9dwcaOR6em5cbGlLQtvLD9dpmsNsXZYPeWYlVTp/XAXrobI5fOTbFaHR zFVQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=google.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=JHPXaRqq Subject: [Intel-wired-lan] [PATCH iwl-next v4] libie: log more info when virtchnl fails X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Li Li via Intel-wired-lan Reply-To: Li Li Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Virtchnl failures can be hard to debug without logs. Logging the details of virtchnl transactions can be useful for debugging virtchnl-related issues. Tested: Built & booted on a test machine and synthetically produced a virtual failure to produce the following log: idpf 0000:01:00.0: Non-zero virtchnl ret val 6 (msg op: 1, data_len: 8); xn id: 0, cookie: 0 idpf 0000:01:00.0: Transaction failed (op 1, xn state: 3, id: 0, cookie: 0, size: 8) Signed-off-by: Li Li --- v4: - Simplify logging to reduce redundant "ret val"s. - Use %u for xn->state. v3: - Use dev_err_ratelimited in both logs. - Move log placement to after virtchnl field validation. - Remove redundant op/cookie fields since they were validated. v2: - Use dev_warn_ratelimited instead of dev_notice_ratelimited based on reviewer feedback. drivers/net/ethernet/intel/libie/controlq.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c index ebc05355e39d..e1bc19d6cdbf 100644 --- a/drivers/net/ethernet/intel/libie/controlq.c +++ b/drivers/net/ethernet/intel/libie/controlq.c @@ -766,6 +766,14 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params, msg_cookie != xn->cookie) return false; + if (ctlq_msg->chnl_retval) { + dev_err_ratelimited( + params->ctlq->dev, + "Non-zero virtchnl ret val %u (msg op: %u, data_len: %u); xn id: %u, cookie: %u\n", + ctlq_msg->chnl_retval, ctlq_msg->chnl_opcode, + ctlq_msg->data_len, xn->index, xn->cookie); + } + spin_lock(&xn->xn_lock); if (xn->state != LIBIE_CTLQ_XN_ASYNC && xn->state != LIBIE_CTLQ_XN_WAITING) { @@ -1011,6 +1019,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params) params->recv_mem = xn->recv_mem; break; default: + dev_err_ratelimited( + params->ctlq->dev, + "Transaction failed (op %u, xn state: %u, id: %u, cookie: %u, size: %zu)\n", + params->chnl_opcode, xn->state, xn->index, xn->cookie, + xn->recv_mem.iov_len); ret = -EBADMSG; break; } -- 2.54.0.545.g6539524ca2-goog