From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5B31CD37BE for ; Mon, 11 May 2026 16:28:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4E497403FF; Mon, 11 May 2026 16:28:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id QHp-YCRvCu_C; Mon, 11 May 2026 16:28:17 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 702A64032E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1778516897; bh=vJlSU8Uv4Mos+oyiqsIwa29218B2Wja/Xm7NhiwexR4=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BG3wySlt5CTW3rYuEta836pxB1Bl6w+vUqoUgVZJb2CTpfDyuG/K0wyuFmkknALPF 4dF+wsvZ8IYCbEWSNz2G1KxtCPN0SsHO2+1J37zZKfCg6saRYkjbZbqYZb3/8iWBgn /YEmzZdgRGZvBwVOqQ1ELZTK9K+L7bnQAy6yh9N3zr8TcLW09ynPBLuOWxoAaW9UBL 9s8BDSpIf95P7Mxf1E85Vpu3winQfHjy/7wCmGH6AxUeM6ItuGWYG3qOGyHBgRfV/k zKUqfzjr+TaXIbKZjUHxde8NG2pdymoIITICJPh/JWqZTH7H3oIc6XFJz/jZXlmNSI zh7B42LUh1wjQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 702A64032E; Mon, 11 May 2026 16:28:17 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id D8425223 for ; Mon, 11 May 2026 16:28:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CA1504032E for ; Mon, 11 May 2026 16:28:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id rwYOw3U8UkVK for ; Mon, 11 May 2026 16:28:16 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 400144031B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 400144031B Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp4.osuosl.org (Postfix) with ESMTPS id 400144031B for ; Mon, 11 May 2026 16:28:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0D655403E9; Mon, 11 May 2026 16:28:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FA99C2BCB0; Mon, 11 May 2026 16:28:11 +0000 (UTC) Date: Mon, 11 May 2026 17:28:09 +0100 From: Simon Horman To: KhaiWenTan Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com, hong.aun.looi@intel.com, hector.blanco.alcaine@intel.com, khai.wen.tan@intel.com, Faizal Rahim Message-ID: <20260511162809.GF27589@horms.kernel.org> References: <20260507214706.309984-1-khai.wen.tan@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260507214706.309984-1-khai.wen.tan@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778516894; bh=NniAWlMwg0MnR6VwlJuOsYihhqkKD5tw4Vf1zwmvhOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FdErAr2g44EhXnJtKEi7rHDBqfcWm0A5OWtbXe1WEibnye4I94d9KVuTYU34JKGWy IGXB3TEIxXv8Sv1tx7NbvltWUQHb43Orf8jMN7lU2Tw8JGmXDOn8AKPo8289yRITae tChraIzauoxsLjkZofATYli3oPIj6hfDzAI1q4Ld6Mq9PHFQar8Vh8dmBTEtsZ4QOm OQdV+DuR1bnzRA/v/6W1PUu9joKz3BbYGWlniw4DeKbNNFg01sWcukZ3q6BRBUZkBb pwq+mQ+q/O9aEZOgBWXX2r1hEoP5UOPQNA0N8Hg059Gb4xPMiAm/9XxHS2etI8f43O GB6wxhZXaRkfg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=FdErAr2g Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 0/4] igc: add support for forcing link speed without autonegotiation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, May 08, 2026 at 05:47:02AM +0800, KhaiWenTan wrote: > From: Faizal Rahim > > This series adds support for forcing 10/100 Mb/s link speed via ethtool > when autonegotiation is disabled on the igc driver. > > Changes in v5: > - add removal justification to include copper context in commit > description for igc: remove unused autoneg_failed field (Paul) > - check that cmd->base.duplex is either DUPLEX_HALF or DUPLEX_FULL > in igc_ethtool_set_link_ksettings() (Simon) > - dynamically override hw->fc.current_mode to igc_fc_none during > link configuration instead of mutating requested_mode (Simon) > > Changes in v4: > - Validate that autoneg is AUTONEG_ENABLE or AUTONEG_DISABLE early > in igc_ethtool_set_link_ksettings() to avoid passing unexpected > values to igc_handle_autoneg_disabled(). (Simon Horman) > > Changes in v3: > - Modify condition from "if (duplex == DUPLEX_HALF)" to > "if (duplex != DUPLEX_FULL)". (Simon Horman) > > Changes in v2: > - When forcing half-duplex, set hw->fc.requested_mode = igc_fc_none, > since half-duplex cannot support flow control per IEEE 802.3. > (Simon Horman) > - Split the original single patch into three patches for clarity: > patches 1 and 2 are preparatory cleanups; patch 3 carries the > functional change. Thanks for your persistence. For the series: Reviewed-by: Simon Horman