From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FFE1CD5BAC for ; Fri, 22 May 2026 08:42:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AE9D742A22; Fri, 22 May 2026 08:42:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3VaoiVeY9WPJ; Fri, 22 May 2026 08:42:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BAA3B429F9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1779439345; bh=K7woSUmQ1qkgC+Tygx9BmDg4D+1VwHe1oVWIu66eemk=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cr8Zzx/SioF4BN6TrFU88yyrlvdSjfZj5nGufIH1KEar0MICPyBuxWSaTuLDrZQSJ OUl0dvFMvXEvIgXOBXOGM5VAYDsGZ4hGT+oUV4x9KNAhc3QDvcqDthZZRGD85UcVj2 fXKVhnfOjRJ6Nq98XmFVVX78UY1tjkWnOqi2pTVJ0TZbfanfFJyMXN9tiX0xDP0ONh lc+SuPFjns24loqZ85mxQAF0DKtiN81Z8GjRtOU1fcUva8AK0TlhhF49PKoX1pgrTB xCZQH1VwnFQUXEy7ENsVy7JVAakfbux2VDuByGiOkKTxDMNYzXu6OhNRvXF/up8NOQ NNonjOsODWHvg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id BAA3B429F9; Fri, 22 May 2026 08:42:25 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 3DE75282 for ; Fri, 22 May 2026 08:42:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2C36F85354 for ; Fri, 22 May 2026 08:42:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kor4NQAfr0Pq for ; Fri, 22 May 2026 08:42:23 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 88D7985348 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 88D7985348 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp1.osuosl.org (Postfix) with ESMTPS id 88D7985348 for ; Fri, 22 May 2026 08:42:23 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 86BD860136; Fri, 22 May 2026 08:42:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFE0B1F00A3D; Fri, 22 May 2026 08:42:20 +0000 (UTC) Date: Fri, 22 May 2026 09:42:18 +0100 From: Simon Horman To: Marcin Szycik Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Michal Swiatkowski , Aleksandr Loktionov , Dave Ertman Message-ID: <20260522084218.GI1506108@horms.kernel.org> References: <20260519112041.125907-1-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519112041.125907-1-marcin.szycik@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779439342; bh=K7woSUmQ1qkgC+Tygx9BmDg4D+1VwHe1oVWIu66eemk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=H1pcDjLXoDj9p0ctuglQNc0j5WKtVAOIoP8JQgQpG1Qyf2908+BSlKXg5wzvgz4Kd tgI8oC+O4A2OhdOb8ngwhYn5ExTRbqrbJTZEHayTbR9La6o7DsM3LPeizCDGbNiQyM FUZ8dq6hTIBfkKd5Xo7AZu9BZLKfUcqDSWFeHmdupFaLuLC5HTEdnxYaTOxiF9ZDAh JMb9HR0evoPSoX+CQ7Si+jJm4G6itYMZAQrxqEiOT9YRtRuzgkPnYz83ACe0ruJatd GIyH2PF2n93RGPKNCVWuR6ovZQ47KHYUOV3gZvG6J9AGxxdff8rh+v/WUUbn5fR/rT 0eKUkjsFZ+qlQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=H1pcDjLX Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix LAG recipe to profile association X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, May 19, 2026 at 01:20:41PM +0200, Marcin Szycik wrote: > ice_init_lag() associates recipes to profiles, assuming that Link > Aggregation-related profiles will always have profile ID lower than 70 > (ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER). This value seems arbitrary and > might not always be valid for some versions of DDP package, i.e. LAG > profiles may have profile ID greater than 70. This would lead to > misconfigured switch and LAG not working properly. > > Fix it by checking up to maximum profile ID. > > Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface") > Signed-off-by: Marcin Szycik > Reviewed-by: Michal Swiatkowski > Reviewed-by: Aleksandr Loktionov > Reviewed-by: Dave Ertman Reviewed-by: Simon Horman I notice that there is an AI review of this patch available on sashiko.dev. However, I believe that flags a pre-existing problem that is orthogonal to this patch. o I do no think that review should block progress of this patch but rather be looked at in the context of possible follow-up.