From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D724C43458 for ; Fri, 26 Jun 2026 22:29:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D025F60F7C; Fri, 26 Jun 2026 22:29:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Wm5j64knlFPt; Fri, 26 Jun 2026 22:29:40 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2C93B60F61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1782512980; bh=z/KOQXjMCL4+K9L12WXoB3UQ4LGC1afxPFJA9hVfjDA=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZX6IdD8cfowCbDUHiThRF0axyH7+02qbG0afJIKXQwJdhx20mLP0ZE1dA2++lITpU 85pem8UV0r/YlkeJvYwM7ic3y21GLX8bNtmk9M1LoVPoBLjRjmctK35HFjbfN9vI+o ft0IAbQkw8g2EcD87iiBKZIsccxyiHgsSc6ezIgx76qAJBA47AnqbqgIGAhpzxYhMs VlKl5k6i2pCPjv8FFvvN4ebXy58t4KUpxcR8mhePGsCWRbu7BgduuYgchHr1rWOo7s K5hu39ZEaGsNCaGEbEDYXCd29gB3FGgwX/uE6//y2mu9TjE/lnyCIkvkhPqROpuPPg DXHOOUVAJGnjg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 2C93B60F61; Fri, 26 Jun 2026 22:29:40 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id CB95528A for ; Fri, 26 Jun 2026 22:29:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BDCEA813AD for ; Fri, 26 Jun 2026 22:29:38 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7TWXxLKBTOXj for ; Fri, 26 Jun 2026 22:29:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org D3389813A9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D3389813A9 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp1.osuosl.org (Postfix) with ESMTPS id D3389813A9 for ; Fri, 26 Jun 2026 22:29:37 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 899D84193B; Fri, 26 Jun 2026 22:29:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 453C21F000E9; Fri, 26 Jun 2026 22:29:37 +0000 (UTC) Date: Fri, 26 Jun 2026 15:29:36 -0700 From: Jakub Kicinski To: Aleksandr Loktionov Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, netdev@vger.kernel.org Message-ID: <20260626152936.7359509f@kernel.org> In-Reply-To: <20260626054730.1126969-2-aleksandr.loktionov@intel.com> References: <20260626054730.1126969-1-aleksandr.loktionov@intel.com> <20260626054730.1126969-2-aleksandr.loktionov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782512977; bh=z/KOQXjMCL4+K9L12WXoB3UQ4LGC1afxPFJA9hVfjDA=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=k2bFpxlt7Wm9C/8eujHy5dBqsKHRHfE+7Phr5425P0zVcZf5P3HfIXdwiYDsF7S7n 49W4wkBiHrCnY8cvl0dQxC+7KyTCydr35Ro8E/qX0lh0b9t+xlGntowCX4gcgTATnD 4XAeKALM4iLKt/KtufF8mdsu8Pq8JerCU9/JKGg6HNv0be+XBKiTzDMmPI6u/4qIA6 H9kMoLRPfq9ptcoD1NvFbRw37q590Hzog7+m1e3atx5xbiDGFmsznRYj4hxW4mbGTO kTu1BWK6XIfWmKkWp6dSUpR8sTaTyh55Hos3O11SlyMAs0+Skdi5SdIwk4uc1H2rhB QA09f1cdtAzIw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=k2bFpxlt Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ethtool: treat RXH_GTP_TEID as intrinsically symmetric X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 26 Jun 2026 07:47:29 +0200 Aleksandr Loktionov wrote: > A GTP tunnel uses the same TEID value in both directions of a flow; > including TEID in the hash input does not break src/dst symmetry. > > ethtool_rxfh_config_is_sym() currently rejects any hash field bitmap > that contains bits outside the four paired L3/L4 fields. This causes > drivers that hash GTP flows on TEID to fail the kernel's preflight > validation in ethtool_check_flow_types(), making it impossible for > those drivers to support symmetric-xor transforms at all. > > Strip RXH_GTP_TEID from the bitmap before the paired-field check so > that drivers may honestly report TEID hashing without blocking the > configuration of symmetric transforms. I don't know much about GTP, but "the Internet" does not seem to agree with your claim: The TEID uniquely identifies the GSN tunnel endpoints. The tunnels for an uplink and a downlink are separate and use a different TEID. https://docs.paloaltonetworks.com/service-providers/10-1/mobile-network-infrastructure-getting-started/gtp/mobile-network-protection-profile So I don't think this will fly..