From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94BC8C531FC for ; Fri, 24 Jul 2026 21:48:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2881460A7C; Fri, 24 Jul 2026 21:48:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WtL4jZvzZ663; Fri, 24 Jul 2026 21:48:31 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0260C606AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1784929711; bh=GTdZSgSwBlfAlIxva5M6ZU/kD9VYoe26BBxVBJ5WdPE=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=1R+Z7yWhN9Vel/S9dtu6qGU1LIqoKEDTT/+Flcn1Tm5+qcFgqulx7UnPYyjR9GVk1 RfwxeIoubV7xLnCwXNzoenXHVAYXOBnGOcfs7InBPJMo9L7+FC905n0B/eDhP+qoHr NYgP4NJC/jAJNf3G0QVe0mRIX0u/sExveXZ2RKmik9xpvd7hcs6iqbeLlaldOoZKGk bAFCh0IMSKO/61A7nMMm3ZLFCkW8WAB/367/VRRtkW3ZB1LOXVjRDB1hu+Qh3aXuAp GpveVz6UTmfHBTPv9ofX61VjHegCsTp6QAY5+kwAWDTOqe9LvmkQnM+FlG3E/i4Rgm 85BSeUUdYTopg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 0260C606AE; Fri, 24 Jul 2026 21:48:31 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 9A8C4357 for ; Fri, 24 Jul 2026 21:48:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 80AE240B60 for ; Fri, 24 Jul 2026 21:48:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Dqq8bhEZQU0y for ; Fri, 24 Jul 2026 21:48:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 8A36140A5A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8A36140A5A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8A36140A5A for ; Fri, 24 Jul 2026 21:48:28 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 1DC3C60A60; Fri, 24 Jul 2026 21:48:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A6FC1F000E9; Fri, 24 Jul 2026 21:48:23 +0000 (UTC) Date: Fri, 24 Jul 2026 14:48:22 -0700 From: Jakub Kicinski To: Sang-Heon Jeon Cc: Julia.Lawall@inria.fr, Alex Deucher , Alexander Shishkin , Alexandre Belloni , Andrew Lunn , Andrew Morton , Arkadiusz Kubalewski , Borislav Petkov , Christian =?UTF-8?B?S8O2bmln?= , Daniel Lezcano , David Airlie , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Florian Westphal , Greg Kroah-Hartman , Hans de Goede , Hans Verkuil , Heikki Krogerus , Herbert Xu , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "James E.J. Bottomley" , Jani Nikula , Jaroslav Kysela , Jason Gunthorpe , Jiri Pirko , "Joerg Roedel (AMD)" , Johan Hovold , Jonathan Cameron , Joonas Lahtinen , Julian Anastasov , Leon Romanovsky , Liam Girdwood , Linus Walleij , Maarten Lankhorst , Mark Brown , "Martin K. Petersen" , Matthew Sakai , Mauro Carvalho Chehab , Maxime Ripard , Michael Turquette , Mike Rapoport , Miri Korenblit , Nicolas Palix , Pablo Neira Ayuso , Paolo Abeni , Ping-Ke Shih , "Rafael J. Wysocki" , Rodrigo Vivi , Sebastian Reichel , Shuah Khan , Simona Vetter , Simon Horman , Stephen Boyd , Steve French , Takashi Iwai , Thomas Renninger , Thomas Zimmermann , Tony Luck , Tvrtko Ursulin , Vadim Fedorenko , Vinod Koul , Will Deacon , Yazen Ghannam , cocci@inria.fr, amd-gfx@lists.freedesktop.org, dmaengine@vger.kernel.org, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-rdma@vger.kernel.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nouveau@lists.freedesktop.org, platform-driver-x86@vger.kernel.org Message-ID: <20260724144822.6af8213f@kernel.org> In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784929705; bh=GTdZSgSwBlfAlIxva5M6ZU/kD9VYoe26BBxVBJ5WdPE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bhpTuvSZWBV7iq9keKc8+pixk18qLEuyMz3ZTlqKcB81KF/CnyeLGI6JSyvHGt9tA E+SxQVBXcXsXsZgtn3HAr+6nPULrU5HRAYu13tTfnL5ffRJr3w0sXxS3y6FSy3SRlS Qe3XQkADPgbjY9nioQHCBPR4pvKP4dL5d3HxM/ORX/63JYStNE+wqJy61XHcdbEpWF xaZAuoqTpynwYjXBJP4BY73AhLP471MMWjcWFGi91teQEabAfmboMZJJ2AI9mVl919 5Vj52Ap+SYxCLa6sCvz56w/tCisRBng0kD6I+yiTKpyHAoJV1VexiywmsHK9mBuUsB 8QLvkwcrgPftA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=bhpTuvSZ Subject: Re: [Intel-wired-lan] [PATCH 00/36] treewide: remove conditional returns with no effect X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 24 Jul 2026 03:45:02 +0900 Sang-Heon Jeon wrote: > Patch 1 adds a Coccinelle script that matches the pattern, including > negation and constant-comparison variants. Where a local variable is > assigned right before the check, the assignment and the two returns > turn into a single return of the assigned expression. Huh, I thought we already had such script. Various script children have been sending such "cleanups" in the past. > Patches 2-36 are generated by the script, with hand fixes to restore > unexpectedly removed comments and to fix the formatting checkpatch.pl > complained about. Please post patches 4,7,8,9 as a separate series. Since you only CCed netdev on subset of the series patchwork thinks there are patches missing and doesn't kick off any CI.