From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: <netdev@vger.kernel.org>, <rafal.romanowski@intel.com>,
<aleksandr.loktionov@intel.com>, <andrew+netdev@lunn.ch>,
<edumazet@google.com>, <marcin.szycik@linux.intel.com>,
<anthony.l.nguyen@intel.com>, <horms@kernel.org>,
<intel-wired-lan@lists.osuosl.org>, <pabeni@redhat.com>,
<davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] ice: fix stats array overflow via proper realloc
Date: Thu, 20 Aug 2026 14:41:09 -0700 [thread overview]
Message-ID: <20260820144109.14e7777b@kernel.org> (raw)
In-Reply-To: <53c50cd8-edfa-4fe3-aec7-a6d66194e635@intel.com>
On Wed, 19 Aug 2026 12:52:39 +0200 Przemek Kitszel wrote:
> I see no point documenting such minor details in commit message.
>
> As a whole, this patch trades a real bug - memory overwrite - for
> a slightly different order of operations and slightly different
> failure point when there is no memory
My concern is that you're backing out of the promise not to turn
a fail in kmalloc() during ethtool -L into a broken interface.
Fix it right?
next prev parent reply other threads:[~2026-08-20 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 20:18 [Intel-wired-lan] [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2026-08-12 (ice) Przemek Kitszel
2026-08-12 20:18 ` [Intel-wired-lan] [PATCH net 1/2] ice: move ice_vsi_realloc_stat_arrays() up Przemek Kitszel
2026-08-12 20:18 ` [Intel-wired-lan] [PATCH net v2 2/2] ice: fix stats array overflow via proper realloc Przemek Kitszel
2026-08-17 20:50 ` Jakub Kicinski
2026-08-19 10:52 ` Przemek Kitszel
2026-08-20 21:41 ` Jakub Kicinski [this message]
2026-08-17 15:55 ` [Intel-wired-lan] [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2026-08-12 (ice) Tony Nguyen
2026-08-17 20:51 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820144109.14e7777b@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rafal.romanowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox