From: Sasha Neftin <sashaneftin@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [iwl-next, v1] igc: remove unreachable break in igc_xdp_run_prog method
Date: Sat, 10 Oct 2026 12:57:27 +0300 [thread overview]
Message-ID: <20261010095727.87751-1-sashaneftin@gmail.com> (raw)
The break after "return IGC_XDP_REDIRECT;" in the XDP_REDIRECT case can
never be reached. Remove it.
No functional change.
Assisted-by: Claude:claude-sonnet-5-5
Signed-off-by: Sasha Neftin <sashaneftin@gmail.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 1fb5f3cbe93c..3b7dd104d8d9 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2525,7 +2525,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,
if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)
goto out_failure;
return IGC_XDP_REDIRECT;
- break;
default:
bpf_warn_invalid_xdp_action(adapter->netdev, prog, act);
fallthrough;
--
2.53.0
next reply other threads:[~2026-10-10 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 9:57 Sasha Neftin [this message]
2026-10-13 20:59 ` [iwl-next, v1] igc: remove unreachable break in igc_xdp_run_prog method Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010095727.87751-1-sashaneftin@gmail.com \
--to=sashaneftin@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox