Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 intel-next 3/3] ice: add write functionality for GNSS TTY
Date: Fri, 22 Apr 2022 09:46:41 -0700	[thread overview]
Message-ID: <2226bdc9-e33a-f797-1bef-3752e01d1401@intel.com> (raw)
In-Reply-To: <20220422114257.2238368-3-karol.kolacinski@intel.com>


On 4/22/2022 4:42 AM, Karol Kolacinski wrote:

<snip>
>   
>   /**
>    * struct gnss_serial - data used to initialize GNSS TTY port
> @@ -33,6 +50,8 @@ struct gnss_serial {
>   	struct mutex gnss_mutex; /* protects GNSS serial structure */
>   	struct kthread_worker *kworker;
>   	struct kthread_delayed_work read_work;
> +	struct kthread_work write_work;
> +	struct list_head queue;
>   };

 > drivers/net/ethernet/intel/ice/ice_gnss.h:56: warning: Function 
parameter or member 'write_work' not described in 'gnss_serial'
 > drivers/net/ethernet/intel/ice/ice_gnss.h:56: warning: Function 
parameter or member 'queue' not described in 'gnss_serial'

>   
>   #if IS_ENABLED(CONFIG_TTY)

  reply	other threads:[~2022-04-22 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 11:42 [Intel-wired-lan] [PATCH v2 intel-next 1/3] ice: remove u16 arithmetic in ice_gnss Karol Kolacinski
2022-04-22 11:42 ` [Intel-wired-lan] [PATCH v2 intel-next 2/3] ice: add i2c write command Karol Kolacinski
2022-04-22 11:42 ` [Intel-wired-lan] [PATCH v2 intel-next 3/3] ice: add write functionality for GNSS TTY Karol Kolacinski
2022-04-22 16:46   ` Tony Nguyen [this message]
2022-04-22 16:43 ` [Intel-wired-lan] [PATCH v2 intel-next 1/3] ice: remove u16 arithmetic in ice_gnss Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2226bdc9-e33a-f797-1bef-3752e01d1401@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox