From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Joe Damato <jdamato@fastly.com>, <intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [RFC, next-queue 0/4] i40e: Add a non-XDP i40e_napi_poll tracepoint
Date: Fri, 7 Oct 2022 13:36:20 -0700 [thread overview]
Message-ID: <25beff49-5564-dd48-c6db-d29b126677a0@intel.com> (raw)
In-Reply-To: <1665165447-1802-1-git-send-email-jdamato@fastly.com>
On 10/7/2022 10:57 AM, Joe Damato wrote:
> Greetings:
>
> This is an RFC which is similar to the series up for review, except that
> this implementation does not touch XDP at all and adds a conditional in
> i40e_napi_poll to only fire the tracepoint when XDP is not enabled.
>
> This should avoid the issues that Maciej has with the naming of out
> parameters (since none of that code is touched in this series) and it
> clears the way for Maciej, Sridhar, et al to implement the XDP tracepoint.
>
> I am submitting this an alternative to what's already up for review.
>
> If you prefer to accept this code, please let me know that you want the
> non-XDP version and I'll submit it as the 'v4'.
Given the discussion, this is the series I prefer. I'm very happy to see
some more debugging helpers coming into the driver so thanks for your
work on this Joe! As for the rest of the team they seem to be fine
speaking for themselves, so I imagine they'll let you know :-)
For the series:
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Best regards,
Jesse
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-10-07 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 17:57 [Intel-wired-lan] [RFC, next-queue 0/4] i40e: Add a non-XDP i40e_napi_poll tracepoint Joe Damato
2022-10-07 17:57 ` [Intel-wired-lan] [RFC, next-queue 1/4] i40e: Store the irq number in i40e_q_vector Joe Damato
2022-10-07 17:57 ` [Intel-wired-lan] [RFC, next-queue 2/4] i40e: Record number TXes cleaned during NAPI Joe Damato
2022-10-07 17:57 ` [Intel-wired-lan] [RFC, next-queue 3/4] i40e: Record number of RXes " Joe Damato
2022-10-07 17:57 ` [Intel-wired-lan] [RFC, next-queue 4/4] i40e: Add i40e_napi_poll tracepoint Joe Damato
2022-10-07 20:36 ` Jesse Brandeburg [this message]
2022-10-07 20:55 ` [Intel-wired-lan] [RFC, next-queue 0/4] i40e: Add a non-XDP " Joe Damato
2022-10-07 21:01 ` Samudrala, Sridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25beff49-5564-dd48-c6db-d29b126677a0@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox