From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A238FC52D7C for ; Wed, 21 Aug 2024 08:10:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 491754037A; Wed, 21 Aug 2024 08:10:30 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AvNS2PQAJzAw; Wed, 21 Aug 2024 08:10:29 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6C050406BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1724227829; bh=+0qJ2/oOU3AActLboRQoEqUOhdAXZ3DXZc816PdUA7o=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=x5LAIXIARIBmYUPkZP88bNiSDe62fqQpHcz0c2KuVAzXBou7JzDGkL/3yym8KMOk9 c+kRR9nRYm6GpysvVCDw9hvW7R8eXEZ3Rsp1CIY59rX35TzZsMA5vkzn5w7Ih9V0P8 kjj+hpPvXaTDPoDgHRSlp9qt96i2irH5tOFHI2FSUCYnOElNYvmejw2IJRxJ5DvpLs LZWqDihZugzZAQ5OdGJch2yIlnAlJ1zVoBGsC611dmHuaixYbIlvEhQgRjs7/HAVu+ gmGz/nmJgDOVZIiZnCS/hoTVxO0mvb3pYggFbfQKDgvIq1Rv6613zkveeawPTcurKM w/BeHva9GeGsQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 6C050406BB; Wed, 21 Aug 2024 08:10:29 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3F02B1BF4E7 for ; Wed, 21 Aug 2024 08:10:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2ABD980E73 for ; Wed, 21 Aug 2024 08:10:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id I5kmvwvLHOSC for ; Wed, 21 Aug 2024 08:10:27 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.9; helo=mgamail.intel.com; envelope-from=dawid.osuchowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 4511480E45 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4511480E45 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4511480E45 for ; Wed, 21 Aug 2024 08:10:27 +0000 (UTC) X-CSE-ConnectionGUID: fe7xm33ISpOi2kL2H66EtQ== X-CSE-MsgGUID: ycNAoTAZSN2NtysonGh4yQ== X-IronPort-AV: E=McAfee;i="6700,10204,11170"; a="33233750" X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="33233750" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 01:10:26 -0700 X-CSE-ConnectionGUID: 6cieWzGsQGKcvRqJz0aKWA== X-CSE-MsgGUID: GxR05bmhT1CNDvyRB5Pb7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="61545390" Received: from dosuchow-mobl2.ger.corp.intel.com (HELO [10.246.27.111]) ([10.246.27.111]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 01:10:25 -0700 Message-ID: <25c69f6d-bd04-429e-a1d5-c6985b6555bf@linux.intel.com> Date: Wed, 21 Aug 2024 10:10:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Maciej Fijalkowski References: <20240820161524.108578-1-dawid.osuchowski@linux.intel.com> Content-Language: pl From: Dawid Osuchowski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724227827; x=1755763827; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ivvgB0cUn8JdRpMYm+PJMRBdz3lefpAdaf3PnAKhIUs=; b=OBacKJXYuNsPWYjo1IYQOsE9vvOCfBbe5eGmfb45NlByfrl14zOWbBLI WTxSV+tJgC/7npTvuTRFCeg+nlp6ZS3Eshf64W/nucuTsChIew3Fpo5aY QTV+qEZkciXIhutyv9h8zqIHHg/3+FL2aL+r4wuM9R6zar6H5YXx4vxa1 L2LDNV1CFTw6FeW2E1tWwb600WEbPiIUHFoZnVJ82hhvBIL8kKkgbeeVW w6giil8hSFHVtfEZ702GI3LT1eACXaAynYnE1DZmVq7gOThqFH+EJNQnH rtXrZKSkEA10zxwLMVV4WBZHCKxdK3jWXaif5EPC6IfCMqDGF7xqgO51+ w==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OBacKJXY Subject: Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: Add netif_device_attach/detach into PF reset flow X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: larysa.zaremba@intel.com, netdev@vger.kernel.org, kalesh-anakkur.purayil@broadcom.com, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Igor Bagnucki Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 21.08.2024 08:22, Maciej Fijalkowski wrote: > On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote: >> @@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type) >> { >> struct device *dev = ice_pf_to_dev(pf); >> struct ice_hw *hw = &pf->hw; >> + struct ice_vsi *vsi = ice_get_main_vsi(pf); > > we have an unwritten rule that is called 'reverse christmas tree' which > requires us to have declarations of variables sorted from longest to > shortest. > > struct ice_vsi *vsi = ice_get_main_vsi(pf); > struct device *dev = ice_pf_to_dev(pf); > struct ice_hw *hw = &pf->hw; > bool dvm; > int err; > My apologies, I was not aware of that unwritten rule. Will fix in next revision, thanks. Other than that, does the rest of the changes look okay to you? --Dawid