From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] idpf: refactor some missing field get/prep conversions
Date: Fri, 1 Dec 2023 08:52:24 +0100 [thread overview]
Message-ID: <266d7d7a-06a2-6d76-e17a-70d37abb04c9@intel.com> (raw)
In-Reply-To: <20231130214511.647586-1-jesse.brandeburg@intel.com>
On 11/30/23 22:45, Jesse Brandeburg wrote:
> Most of idpf correctly uses FIELD_GET and FIELD_PREP, but a couple spots
> were missed so fix those.
>
> This conversion was automated via a coccinelle script as posted with the
> previous series.
[1]
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> This patch should be applied after the larger FIELD_PREP/FIELD_GET
> conversion series for the Intel drivers.
or at the end of,
so [1] would be self-explanatory
> ---
> .../ethernet/intel/idpf/idpf_singleq_txrx.c | 7 +++----
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 18 ++++++++----------
> 2 files changed, 11 insertions(+), 14 deletions(-)
>
Anyway,
it is better code so,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-12-01 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 21:45 [Intel-wired-lan] [PATCH iwl-next v1] idpf: refactor some missing field get/prep conversions Jesse Brandeburg
2023-12-01 7:52 ` Przemek Kitszel [this message]
2023-12-01 14:32 ` Alexander Lobakin
2023-12-01 20:12 ` Jesse Brandeburg
2023-12-01 20:43 ` Julia Lawall
2023-12-04 10:26 ` Alexander Lobakin
2023-12-06 1:10 ` Jesse Brandeburg
2023-12-06 12:33 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=266d7d7a-06a2-6d76-e17a-70d37abb04c9@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox