From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Mateusz Palczewski <mateusz.palczewski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: SlawomirX Laba <slawomirx.laba@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v1 1/2] iavf: Fix shutdown pci callback to match the remove one
Date: Tue, 12 Jul 2022 15:01:52 -0700 [thread overview]
Message-ID: <270002d5-1159-7950-33fa-44417f22b0ca@intel.com> (raw)
In-Reply-To: <20220706135437.1695672-2-mateusz.palczewski@intel.com>
On 7/6/2022 6:54 AM, Mateusz Palczewski wrote:
> From: SlawomirX Laba <slawomirx.laba@intel.com>
From:/Signed-off-by: email name mismatch: 'From: SlawomirX Laba
<slawomirx.laba@intel.com>' != 'Signed-off-by: Slawomir Laba
<slawomirx.laba@intel.com>'
> Make the flow for pci shutdown be the same to the pci remove.
>
> iavf_shutdown was implementing an incomplete version
> of iavf_remove. It misses several calls to the kernel like
> iavf_free_misc_irq, iavf_reset_interrupt_capability, iounmap
> that might break the system on reboot or hibernation.
>
> Implement the call of iavf_remove directly in iavf_shutdown to
> close this gap.
>
> Fixes: 5eae00c57f5e ("i40evf: main driver core")
> Signed-off-by: Slawomir Laba <slawomirx.laba@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
Same issue for patch 2.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2022-07-12 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 13:54 [Intel-wired-lan] [PATCH net v1 0/2] Fix close path on shutdown and remove in iavf driver Mateusz Palczewski
2022-07-06 13:54 ` [Intel-wired-lan] [PATCH net v1 1/2] iavf: Fix shutdown pci callback to match the remove one Mateusz Palczewski
2022-07-12 22:01 ` Tony Nguyen [this message]
2022-07-06 13:54 ` [Intel-wired-lan] [PATCH net v1 2/2] iavf: Fix race condition between iavf_shutdown and iavf_remove Mateusz Palczewski
-- strict thread matches above, loose matches on Subject: below --
2022-07-04 12:41 [Intel-wired-lan] [PATCH net v1 1/2] iavf: Fix shutdown pci callback to match the remove one Mateusz Palczewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=270002d5-1159-7950-33fa-44417f22b0ca@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.palczewski@intel.com \
--cc=slawomirx.laba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox