From: Sasha Neftin <sasha.neftin@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID
Date: Wed, 22 Sep 2021 10:15:51 +0300 [thread overview]
Message-ID: <2a9ee721-de1e-0012-bc9c-cb47b384cacf@intel.com> (raw)
In-Reply-To: <9cb08013-19f0-1c27-339e-63b3700c26f2@molgen.mpg.de>
On 9/10/2021 10:28, Paul Menzel wrote:
> Dear Sasha,
>
>
> Thank you for the patch.
>
>
> Am 09.09.21 um 19:49 schrieb Sasha Neftin:
>
> Please mention the device in the commit message summary:
>
>> igc: Update I226_k device ID
>
>
>> Update device ID for the I226_K part.
>
> Some background would be nice, where the old/wrong(?) ID came from, and
> where the new one is specified.
Align to the latest documentation comes from our HW architecture team.
>
>
> Kind regards,
>
> Paul
>
>
>> Fixes: bfa5e98c9de4 ("igc: Add new device ID")
>> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
>> ---
>> ? drivers/net/ethernet/intel/igc/igc_hw.h | 2 +-
>> ? 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h
>> b/drivers/net/ethernet/intel/igc/igc_hw.h
>> index 772fd06e93ac..587db7483f25 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_hw.h
>> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h
>> @@ -22,9 +22,9 @@
>> ? #define IGC_DEV_ID_I220_V??????????? 0x15F7
>> ? #define IGC_DEV_ID_I225_K??????????? 0x3100
>> ? #define IGC_DEV_ID_I225_K2??????????? 0x3101
>> +#define IGC_DEV_ID_I226_K??????????? 0x3102
>> ? #define IGC_DEV_ID_I225_LMVP??????????? 0x5502
>> ? #define IGC_DEV_ID_I226_LMVP??????????? 0x5503
>> -#define IGC_DEV_ID_I226_K??????????? 0x5504
>> ? #define IGC_DEV_ID_I225_IT??????????? 0x0D9F
>> ? #define IGC_DEV_ID_I226_LM??????????? 0x125B
>> ? #define IGC_DEV_ID_I226_V??????????? 0x125C
>>
Thanks for the review.
next prev parent reply other threads:[~2021-09-22 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 17:49 [Intel-wired-lan] [PATCH v1 1/1] igc: Update the device ID Sasha Neftin
2021-09-10 7:28 ` Paul Menzel
2021-09-22 7:15 ` Sasha Neftin [this message]
2021-09-12 13:45 ` Kraus, NechamaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a9ee721-de1e-0012-bc9c-cb47b384cacf@intel.com \
--to=sasha.neftin@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox