Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Michal Wilczynski <michal.wilczynski@intel.com>,
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 2/2] ice: Fix promiscuous mode not turning off
Date: Tue, 28 Jun 2022 15:09:06 -0700	[thread overview]
Message-ID: <30eee1c9-5cb0-4c30-b4e7-fb801fcccd3d@intel.com> (raw)
In-Reply-To: <20220624101611.1007933-3-michal.wilczynski@intel.com>



On 6/24/2022 3:16 AM, Michal Wilczynski wrote:
> When trust is turned off for the VF, the expectation is that
> promiscuous and allmulticast filters are removed.
> Currently default VSI filter is not getting cleared in this
> flow.
> 
> Example:
> 
> ip link set enp236s0f0 vf 0 trust on
> ip link set enp236s0f0v0 promisc on
> ip link set enp236s0f0 vf 0 trust off
> /* promiscuous mode is still enabled on VF0 */

Why not net?

> Remove switch filters for both cases.
> This commit fixes above behavior by removing default VSI filters
> and allmulticast filters when vf-true-promisc-support is OFF.
> 
> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  reply	other threads:[~2022-06-28 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 10:16 [Intel-wired-lan] [PATCH net-next v1 0/2] Improvements for default VSI filter handling Michal Wilczynski
2022-06-24 10:16 ` [Intel-wired-lan] [PATCH net-next v1 1/2] ice: Introduce enabling promiscuous mode on multiple VF's Michal Wilczynski
2022-06-28 22:06   ` Tony Nguyen
2022-07-01 15:21     ` Wilczynski, Michal
2022-06-24 10:16 ` [Intel-wired-lan] [PATCH net-next v1 2/2] ice: Fix promiscuous mode not turning off Michal Wilczynski
2022-06-28 22:09   ` Tony Nguyen [this message]
2022-07-01 15:20     ` Wilczynski, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30eee1c9-5cb0-4c30-b4e7-fb801fcccd3d@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=michal.wilczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox