From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DDC7C19F2A for ; Thu, 4 Aug 2022 13:03:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D0EB16072A; Thu, 4 Aug 2022 13:03:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D0EB16072A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1659618210; bh=x3qiVGChWXTmjjHZr1lOzp/DQpeqeFsCpirsMGYVBZo=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=CEvh2tgMwgKiaxVXRQmiFM1h2AyqxhXtyrOKjJV4uKgMR80K4KOa420P+D4QCPCi5 uCU/8Uelf06IhHeY0LioEIB3KucTcwLlKYQLQPxzODD5gDyd8D1Hm8YmP3lyWDActd Tbr7wdAqgt9j+F4IjcsQoOV85/XpdLfTK+bgknafX3tjUnQfrJC0VeGWqFipkZmyG4 VTLYL1q2Nxj3NQzAR/2c+99mUX38o8+M0WtgBaY5mn8zvx7aHNOh+5NQj3swuHH5tE X1Rcbe+zPOYWk4FrwXDjgnAJ2QMnPI4cHauAkHT4lFhjBnJ0d3ROxP3lCKJ7bLg3U3 Yk5wKEAVHAO8g== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T9ZXCa0_0oJz; Thu, 4 Aug 2022 13:03:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id BE87C60BD1; Thu, 4 Aug 2022 13:03:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BE87C60BD1 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 8860E1BF47D for ; Thu, 4 Aug 2022 13:03:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 62C28409ED for ; Thu, 4 Aug 2022 13:03:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 62C28409ED X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EoEkebbia14W for ; Thu, 4 Aug 2022 13:03:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 548BB40407 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp2.osuosl.org (Postfix) with ESMTPS id 548BB40407 for ; Thu, 4 Aug 2022 13:03:27 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 96744B8249B; Thu, 4 Aug 2022 13:03:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9730BC433D7; Thu, 4 Aug 2022 13:03:22 +0000 (UTC) From: James Hogan To: Jesse Brandeburg , Vinicius Costa Gomes Date: Thu, 04 Aug 2022 14:03:19 +0100 Message-ID: <3198206.44csPzL39Z@saruman> In-Reply-To: <4755499.31r3eYUQgx@saruman> References: <4752347.31r3eYUQgx@saruman> <874jz2ei5m.fsf@intel.com> <4755499.31r3eYUQgx@saruman> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659618203; bh=LbeNqdkoY3m/gjL8HjgTyjrjBHt8dQoEyUOGJRb5eVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WJUyjQwc/4wTqoXSjdlX+0ZIvgxhpfgXKgBFiUl07215Pw+gcL8R+EDlTBWAQVL/h XiuaiRmpWMRN6Epsh8RYDmT3jIdSIbs0TyNcw/i/so5lYK2k9Bbsl0ijgdwdBHp83s 2+wNt6Synzw7We7stWUeyFlS04XHWEoeZiVn1K8HSR4uLjhUt6zizNus44HHbF2HxG AQ6BUlTs3BR0O9j1K7ctmY7BoG78zTZ/1ZTUCzOdagZQMdQ3multWpQYaxHvr+uCfT 2AjY0BZ6V5qeEp9Qu/gPVVFLhKYph5qM6Re9x1Lnp0+d8OHz+RZ3T1FR7RAVZCoy6r L+8Y5kaEH2+AA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WJUyjQwc Subject: Re: [Intel-wired-lan] I225-V (igc driver) hangs after resume in igc_resume/igc_tsn_reset X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi, On Thursday, 28 July 2022 18:36:31 BST James Hogan wrote: > On Wednesday, 27 July 2022 15:37:09 BST Vinicius Costa Gomes wrote: > > Yeah, I agree that it seems like the issue is something else. I would > > suggest start with the "simple" things, enabling 'CONFIG_PROVE_LOCKING' > > and looking at the first splat, it could be that what you are seeing is > > caused by a deadlock somewhere else. > > This is revealing I think (re-enabled PCIE_PTM and enabled PROVE_LOCKING). > > In this case it happened within minutes of boot, but a few previous attempts > with several suspend cycles with the same kernel didn't detect the same > thing. I hate to nag, but any thoughts on the lockdep recursive locking warning below? It seems to indicate a recursive taking of rtnl_mutex in dev_ethtool and igc_resume, which would certainly seem to point the finger squarely back at the igc driver. All the best, James > > NetworkManager[857]: [1659028974.1752] device (enp6s0): state > change: activated -> unavailable (reason 'carrier-changed', > sys-iface-state: 'managed') > > ============================================ > WARNING: possible recursive locking detected > 5.18.12-arch1-1 #2 Not tainted > -------------------------------------------- > NetworkManager/857 is trying to acquire lock: > ffffffff9f9e9048 (rtnl_mutex){+.+.}-{3:3}, at: igc_resume+0xf6/0x1d0 [igc] > > but task is already holding lock: > ffffffff9f9e9048 (rtnl_mutex){+.+.}-{3:3}, at: dev_ethtool+0xaf/0x3080 > > other info that might help us debug this: > Possible unsafe locking scenario: > CPU0 > ---- > lock(rtnl_mutex); > lock(rtnl_mutex); > > *** DEADLOCK *** > May be due to missing lock nesting notation > 1 lock held by NetworkManager/857: > #0: ffffffff9f9e9048 (rtnl_mutex){+.+.}-{3:3}, at: dev_ethtool+0xaf/0x3080 > > stack backtrace: > CPU: 0 PID: 857 Comm: NetworkManager Not tainted 5.18.12-arch1-1 #2 > 369425cead7bf2331cd4c5d2279465ad4a0fc21f Hardware name: Micro-Star > International Co., Ltd. MS-7D25/PRO Z690-A DDR4(MS-7D25), BIOS 1.40 > 05/17/2022 Call Trace: > > dump_stack_lvl+0x5f/0x78 > __lock_acquire.cold+0xd4/0x2e5 > ? __lock_acquire+0x3b2/0x1fd0 > lock_acquire+0xc8/0x2d0 > ? igc_resume+0xf6/0x1d0 [igc beed6d83546b18fcf82fbbfaeea59871823bceeb] > ? lock_is_held_type+0xaa/0x120 > __mutex_lock+0xb6/0x830 > ? igc_resume+0xf6/0x1d0 [igc beed6d83546b18fcf82fbbfaeea59871823bceeb] > ? lockdep_hardirqs_on_prepare+0xdd/0x180 > ? _raw_spin_unlock_irqrestore+0x34/0x50 > ? igc_resume+0xf6/0x1d0 [igc beed6d83546b18fcf82fbbfaeea59871823bceeb] > ? igc_resume+0xf6/0x1d0 [igc beed6d83546b18fcf82fbbfaeea59871823bceeb] > igc_resume+0xf6/0x1d0 [igc beed6d83546b18fcf82fbbfaeea59871823bceeb] > pci_pm_runtime_resume+0xab/0xd0 > ? pci_pm_freeze_noirq+0xe0/0xe0 > __rpm_callback+0x41/0x160 > rpm_callback+0x35/0x70 > ? pci_pm_freeze_noirq+0xe0/0xe0 > rpm_resume+0x5eb/0x820 > __pm_runtime_resume+0x4b/0x80 > dev_ethtool+0x128/0x3080 > ? lock_is_held_type+0xaa/0x120 > ? find_held_lock+0x2b/0x80 > ? dev_load+0x57/0x140 > ? lock_release+0xd4/0x2d0 > dev_ioctl+0x155/0x560 > sock_do_ioctl+0xd7/0x120 > sock_ioctl+0x103/0x360 > ? __fget_files+0xd2/0x170 > __x64_sys_ioctl+0x8e/0xc0 > do_syscall_64+0x5c/0x90 > ? do_syscall_64+0x6b/0x90 > ? lockdep_hardirqs_on_prepare+0xdd/0x180 > ? do_syscall_64+0x6b/0x90 > ? lockdep_hardirqs_on_prepare+0xdd/0x180 > ? do_syscall_64+0x6b/0x90 > ? asm_sysvec_apic_timer_interrupt+0xe/0x20 > ? rcu_read_lock_sched_held+0x40/0x80 > entry_SYSCALL_64_after_hwframe+0x44/0xae > RIP: 0033:0x7f2c35d077af > Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 > 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 > ff ff 77 18 48 8b 44 24 18 64 48 2b 04 25 28 00 00 RSP: > 002b:00007ffd7319afd0 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: > ffffffffffffffda RBX: 00007ffd7319b2c0 RCX: 00007f2c35d077af > RDX: 00007ffd7319b0f0 RSI: 0000000000008946 RDI: 0000000000000012 > RBP: 00007ffd7319b270 R08: 0000000000000000 R09: 00007ffd7319b2c8 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007ffd7319b0f0 R14: 00007ffd7319b0d0 R15: 00007ffd7319b0d0 > > > Cheers > James _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan