From: Ivan Vecera <ivecera@redhat.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Rob Herring <robh@kernel.org>, Leon Romanovsky <leon@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-rdma@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Richard Cochran <richardcochran@gmail.com>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Willem de Bruijn <willemb@google.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
netdev@vger.kernel.org, Mark Bloch <mbloch@nvidia.com>,
linux-kernel@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Stefan Wahren <wahrenst@gmx.net>, Simon Horman <horms@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH RFC net-next 06/13] dpll: Support dynamic pin index allocation
Date: Mon, 15 Dec 2025 15:43:52 +0100 [thread overview]
Message-ID: <31e2a687-7e5d-40f2-ba5a-0c05db10e5ae@redhat.com> (raw)
In-Reply-To: <7204d8f7-6482-4217-998f-2788d55f4235@intel.com>
On 12/15/25 3:10 PM, Przemek Kitszel wrote:
> On 12/11/25 20:47, Ivan Vecera wrote:
>> Allow drivers to register DPLL pins without manually specifying a pin
>> index.
>>
>> Currently, drivers must provide a unique pin index when calling
>> dpll_pin_get(). This works well for hardware-mapped pins but creates
>> friction for drivers handling virtual pins or those without a strict
>> hardware indexing scheme.
>
> wouldn't it be better to just switch everything to allocated IDs?
>
No, this would break original dpll_pin_get() logic. If a caller use
dynamic pin index allocation then in practice means that a new pin
is allocated. But if I have a HW pin with specific index then I want
to get the same ref-counted dpll_pin pointer by dpll_pin_get().
Ivan
next prev parent reply other threads:[~2025-12-15 14:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 19:47 [Intel-wired-lan] [PATCH RFC net-next 00/13] dpll: Core improvements and ice E825-C SyncE support Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 01/13] dt-bindings: net: ethernet-controller: Add DPLL pin properties Ivan Vecera
2025-12-11 19:56 ` Andrew Lunn
2025-12-14 20:41 ` Ivan Vecera
2025-12-17 0:49 ` Rob Herring
2026-01-05 16:23 ` Ivan Vecera
2026-01-07 15:15 ` Rob Herring
2026-01-07 16:23 ` Ivan Vecera
2026-01-07 17:31 ` Andrew Lunn
2026-01-07 19:18 ` Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 02/13] dpll: Allow registering pin with firmware node Ivan Vecera
2025-12-12 11:25 ` Jiri Pirko
2025-12-14 19:35 ` Ivan Vecera
2025-12-15 13:08 ` Jiri Pirko
2025-12-15 13:51 ` Ivan Vecera
2025-12-15 14:09 ` Jiri Pirko
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 03/13] net: eth: Add helpers to find DPLL pin " Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 04/13] dpll: zl3073x: register pins with fwnode handle Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 05/13] dpll: Add notifier chain for dpll events Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 06/13] dpll: Support dynamic pin index allocation Ivan Vecera
2025-12-15 14:10 ` Przemek Kitszel
2025-12-15 14:43 ` Ivan Vecera [this message]
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 07/13] dpll: zl3073x: Add support for mux pin type Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 08/13] dpll: Enhance and consolidate reference counting logic Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 09/13] dpll: Prevent duplicate registrations Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 10/13] dpll: Add reference count tracking support Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 11/13] dpll: zl3073x: Enable reference count tracking Ivan Vecera
2025-12-12 11:11 ` Jiri Pirko
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 12/13] ice: dpll: " Ivan Vecera
2025-12-11 19:47 ` [Intel-wired-lan] [PATCH RFC net-next 13/13] ice: dpll: Support E825-C SyncE and dynamic pin discovery Ivan Vecera
2025-12-12 10:20 ` Loktionov, Aleksandr
2025-12-14 19:30 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e2a687-7e5d-40f2-ba5a-0c05db10e5ae@redhat.com \
--to=ivecera@redhat.com \
--cc=Prathosh.Satish@microchip.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=jonathan.lemon@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wahrenst@gmx.net \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox