From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88591C2BD09 for ; Thu, 27 Jun 2024 16:58:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0CC9160770; Thu, 27 Jun 2024 16:58:08 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7uz9EH9XURk5; Thu, 27 Jun 2024 16:58:06 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A276160749 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1719507486; bh=PenMp7vS8XlisAM41TFuzVihkYFaLUEzYIJvh+AQm4M=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=FN5GXUIpDrJqmYF8P0qvd7LWoS7thRCZjPwj2fJ2yWbBLBuQmDqSepYkCCJGuakoO qCu4BKI2mOGbxaEIEoJCG8MCZ4jUBr21dolyxrwsKH1xrYDFpQe9ddDDjS8VFNRoZ0 928IzVOfyVc9ea/2SepnfB6Cuizus2tB45hH/8eK7WvOdIcZMFM8W6RMTC5gPY63N+ Kh0oOFK4mXKwO7+vtx0GusmtREakZqtkuJ5orgH2UesntQupnss8smyuTgT/fKzpmB WqoZKQ2oGwvbmnOAYNtgWUIDDWGLXMHgrST8sPQxTgD3BskjRUbhW4ZWT3xFu+11eC uakPzm7mYtBnw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A276160749; Thu, 27 Jun 2024 16:58:06 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 2F29F1BF3E8 for ; Thu, 27 Jun 2024 16:58:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1918A840BB for ; Thu, 27 Jun 2024 16:58:05 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id rTvTroEKgyp4 for ; Thu, 27 Jun 2024 16:58:04 +0000 (UTC) X-Greylist: delayed 522 seconds by postgrey-1.37 at util1.osuosl.org; Thu, 27 Jun 2024 16:58:03 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 095CD83F25 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 095CD83F25 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=88.99.2.238; helo=mx0.woks-audio.com; envelope-from=benjamin.steinke@woks-audio.com; receiver= Received: from mx0.woks-audio.com (mx0.woks-audio.com [88.99.2.238]) by smtp1.osuosl.org (Postfix) with ESMTPS id 095CD83F25 for ; Thu, 27 Jun 2024 16:58:03 +0000 (UTC) From: Benjamin Steinke To: Sriram Yagnaraman Date: Thu, 27 Jun 2024 18:49:16 +0200 Message-ID: <3253130.2gtjKKCVsX@desktop> In-Reply-To: <878qyq9838.fsf@kurt.kurt.home> References: <20230804084051.14194-1-sriram.yagnaraman@est.tech> <878qyq9838.fsf@kurt.kurt.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-ClientProxiedBy: EX1.jas.loc (10.100.2.20) To EX1.jas.loc (10.100.2.20) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=woks-audio.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=woks; bh=PenMp7vS8XlisAM41TFu zVihkYFaLUEzYIJvh+AQm4M=; b=lt3HoQarHo9VA33X7Km44EYZTJn6MR3RS5ju rGkivuCCAtTecsXv27sxu/+Ly0vBKd54+wsKHEPeoo/fdlVvYH/+9ZX/69bFcP8+ ID4IeSVKR04lRSgCMQMUrJ8gOMNpwEbnpJdy/PB1oG0vsbfs9b1XuDAEhsSQnvom xIX1IbeUQbvJ0HgJaFImNkt4VQQYKfdyWzhaKGgyyfWOn0IjjmDGW/BulTFAEQA3 U+TjFRObSC55+3aiU3XOgEwHNeB6F3QuVXMpvQzstyUAqhQEc0YNwWuBMV2PUqnj aiTMcl00EPJzsBoIeA0Ak1obnUSYo70cSa5myqjl6t+sWU1bUw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=woks-audio.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=woks-audio.com header.i=@woks-audio.com header.a=rsa-sha256 header.s=woks header.b=lt3HoQar Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/4] igb: Add support for AF_XDP zero-copy X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maciej Fijalkowski , Jesper Dangaard Brouer , Daniel Borkmann , intel-wired-lan@osuosl.org, Kurt Kanzenbach , John Fastabend , Alexei Starovoitov , Sriram Yagnaraman , =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= , netdev@vger.kernel.org, Tony Nguyen , Magnus Karlsson , Jonathan Lemon , Jakub Kicinski , bpf@vger.kernel.org, Paolo Abeni , "David S . Miller" , Eric Dumazet Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thursday, 27 June 2024, 09:07:55 CEST, Kurt Kanzenbach wrote: > Hi Sriram, > > On Fri Aug 04 2023, Sriram Yagnaraman wrote: > > The first couple of patches adds helper funcctions to prepare for AF_XDP > > zero-copy support which comes in the last couple of patches, one each > > for Rx and TX paths. > > > > As mentioned in v1 patchset [0], I don't have access to an actual IGB > > device to provide correct performance numbers. I have used Intel 82576EB > > emulator in QEMU [1] to test the changes to IGB driver. > > I gave this patch series a try on a recent kernel and silicon > (i210). There was one issue in igb_xmit_zc(). But other than that it > worked very nicely. Hi Kurt and Sriram, I recently tried the patches on a 6.1 kernel. On two different devices i210 & i211 I couldn't see any packets being transmitted on the wire. Perhaps caused by the issue in igb_xmit_zc() you mentioned, Kurt? Can you share your findings, please? RX seemed to work on first sight. > It seems like it hasn't been merged yet. Do you have any plans for > continuing to work on this? I can offer to do testing and debugging on real hardware if this helps. Thanks, Benjamin