From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Aaron Ma <aaron.ma@canonical.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [Intel-wired-lan] [PATCH] igb: fix hang issue of AER error during resume
Date: Tue, 6 Jun 2023 10:28:21 -0700 [thread overview]
Message-ID: <3279e4c3-2a26-9a77-0334-292fee0c0510@intel.com> (raw)
In-Reply-To: <20230526163001.67626-1-aaron.ma@canonical.com>
On 5/26/2023 9:30 AM, Aaron Ma wrote:
Could you designate the target tree for the patch (net or net-next). I
presume it's net...
> PCIe AER error_detected caused a race issue with igb_resume.
> Protect error_detected when igb is in down state.
>
> Error logs:
> kernel: igb 0000:02:00.0: disabling already-disabled device
> kernel: WARNING: CPU: 0 PID: 277 at drivers/pci/pci.c:2248 pci_disable_device+0xc4/0xf0
> kernel: RIP: 0010:pci_disable_device+0xc4/0xf0
> kernel: Call Trace:
> kernel: <TASK>
> kernel: igb_io_error_detected+0x3e/0x60
> kernel: report_error_detected+0xd6/0x1c0
> kernel: ? __pfx_report_normal_detected+0x10/0x10
> kernel: report_normal_detected+0x16/0x30
> kernel: pci_walk_bus+0x74/0xa0
> kernel: pcie_do_recovery+0xb9/0x340
> kernel: ? __pfx_aer_root_reset+0x10/0x10
> kernel: aer_process_err_devices+0x168/0x220
> kernel: aer_isr+0x1b5/0x1e0
> kernel: ? __pfx_irq_thread_fn+0x10/0x10
> kernel: irq_thread_fn+0x21/0x70
> kernel: irq_thread+0xf8/0x1c0
> kernel: ? __pfx_irq_thread_dtor+0x10/0x10
> kernel: ? __pfx_irq_thread+0x10/0x10
> kernel: kthread+0xef/0x120
> kernel: ? __pfx_kthread+0x10/0x10
> kernel: ret_from_fork+0x29/0x50
> kernel: </TASK>
> kernel: ---[ end trace 0000000000000000 ]---
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217446
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
... which should have a Fixes: tag since this is bug fix.
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Thanks,
Tony
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-06-06 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 16:30 [Intel-wired-lan] [PATCH] igb: fix hang issue of AER error during resume Aaron Ma
2023-06-06 14:16 ` Palczewski, Mateusz
2023-06-06 17:28 ` Tony Nguyen [this message]
2023-06-07 1:56 ` [Intel-wired-lan] [PATCH net v2] " Aaron Ma
2023-07-13 23:38 ` Mekala, SunithaX D
2023-07-14 5:18 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3279e4c3-2a26-9a77-0334-292fee0c0510@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aaron.ma@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox