From: "Kaminski, Pawel" <pawel.kaminski@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
intel-wired-lan@osuosl.org,
Michal Wilczynski <michal.wilczynski@intel.com>,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: Add support for devlink loopback param.
Date: Wed, 6 Dec 2023 18:26:13 -0600 [thread overview]
Message-ID: <340900d4-b30a-4387-9ce2-1971e8d8024c@intel.com> (raw)
In-Reply-To: <20231201183704.382f5964@kernel.org>
On 2023-12-01 20:37, Jakub Kicinski wrote:
> On Fri, 1 Dec 2023 15:59:49 -0800 Pawel Kaminski wrote:
>> Add support for devlink loopback param. Supported values are "enabled",
>> "disabled" and "prioritized". Default configuration is set to "enabled.
>>
>> By default loopback traffic BW is locked to PF configured BW.
>
> First off - hairpin-bandwidth or some such would be a much better name.
> Second - you must explain every devlink param in Documentation/
>
> Also admission ctrl vs prioritizing sounds like different knobs.
While at certain abstraction level I agree, in my opinion it is not
worth here to divide this to separate knobs, since underlying logic (FW)
doesn't follow that anyways. It is driver specific and extremely
unlikely to change in the future. Hopefully next gen card will not need
this knob at all.
>> HW is
>> capable of higher speeds on loopback traffic. Loopback param set to
>> "prioritized" enables HW BW prioritization for VF to VF traffic,
>> effectively increasing BW between VFs. Applicable to 8x10G and 4x25G
>> cards.
>
> Not very clear what this means...
> So the VFs are Tx bandwidth limited to link speed.
> How does the device know it can admit extra traffic?
> Presumably this doesn't affect rates set by devlink rate?
I will rewrite the description and explanation in v2 and include
documentation change.
Thank you,
PK
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-12-07 0:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 23:59 [Intel-wired-lan] [PATCH iwl-next v1] ice: Add support for devlink loopback param Pawel Kaminski
2023-12-02 2:37 ` Jakub Kicinski
2023-12-07 0:26 ` Kaminski, Pawel [this message]
2024-02-26 9:40 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=340900d4-b30a-4387-9ce2-1971e8d8024c@intel.com \
--to=pawel.kaminski@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=kuba@kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox