From: Jacob Keller <jacob.e.keller@intel.com>
To: <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [net-next v4] intel: make module parameters readable in sys filesystem
Date: Fri, 16 Feb 2024 14:26:22 -0800 [thread overview]
Message-ID: <3432f3f0-b4c6-4717-932c-3b76f487cfae@intel.com> (raw)
In-Reply-To: <20240215220101.248023-1-jmaxwell37@gmail.com>
On 2/15/2024 2:01 PM, Jon Maxwell wrote:
> Linux users sometimes need an easy way to check current values of module
> parameters. For example the module may be manually reloaded with different
> parameters. Make these visible and readable in the /sys filesystem to allow
> that. But don't make the "debug" module parameter visible as debugging is
> enabled via ethtool msglvl.
>
> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
Makes sense. I hadn't previously looked closely at the definition of
module_param so I was a bit confused that it was this easy to enable the
parameters in sysfs. Nice.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-02-16 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 22:01 [Intel-wired-lan] [net-next v4] intel: make module parameters readable in sys filesystem Jon Maxwell
2024-02-16 22:26 ` Jacob Keller [this message]
2024-02-22 17:08 ` Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3432f3f0-b4c6-4717-932c-3b76f487cfae@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox