Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] ixgbevf: Remove limit of 10 entries for unicast filter list
Date: Wed, 8 Jan 2020 14:47:20 -0800	[thread overview]
Message-ID: <35f3bcec-6685-d6c3-8842-09fc1729dd57@intel.com> (raw)
In-Reply-To: <ff7c1cc5-3bec-3ce7-f584-6fb1ef1f9cbe@gmail.com>



On 11/25/2019 11:14 AM, Gregory Rose wrote:
> 
> It's tough to recall exactly what my thinking was - 8 years is a long 
> time.? However, I think you're
> right that this is about resource sharing and not allowing any single VF 
> to consume all the remaining
> RAR entries.? Ten entries seems arbitrary but I do recall at the time a 
> common test setup was with
> 4 VFs.? Also, we needed to reserve RAR entries for the PF too IIRC.
> 
> Maybe Sibai can recall, I don't know if she's still at Intel but maybe 
> ask her as well.
> 
> Sorry I couldn't be more help.
> 
> Regards,
> 
> - Greg

Right. This is what I would have thought as well. By not limiting, we
potentially allow one VF to hog all of the resources.

It's plausible that this limit ought to be configurable instead of
static. This way, a system administrator could change the limit on the
PF and enable more entries than the static limit of 10.

That obviously requires more plumbing in place to represent the limit
and find an adequate way of informing the PF system administrator...

Thanks,
Jake

  reply	other threads:[~2020-01-08 22:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 14:24 [Intel-wired-lan] [PATCH v2] ixgbevf: Remove limit of 10 entries for unicast filter list Radoslaw Tyl
2019-11-25 13:32 ` Paul Menzel
2019-11-25 18:23   ` Alexander Duyck
2019-11-25 19:14     ` Gregory Rose
2020-01-08 22:47       ` Jacob Keller [this message]
2019-11-25 13:49 ` Paul Menzel
2019-12-04 18:53 ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35f3bcec-6685-d6c3-8842-09fc1729dd57@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox