From: Florian Fainelli <f.fainelli@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 06/11] phy: un-inline devm_mdiobus_register()
Date: Mon, 22 Jun 2020 16:55:39 -0700 [thread overview]
Message-ID: <39e761f3-6607-d209-61df-535330f50db3@gmail.com> (raw)
In-Reply-To: <20200622100056.10151-7-brgl@bgdev.pl>
On 6/22/20 3:00 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Functions should only be static inline if they're very short. This
> devres helper is already over 10 lines and it will grow soon as we'll
> be improving upon its approach. Pull it into mdio_devres.c.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/net/phy/Makefile | 2 +-
> drivers/net/phy/mdio_devres.c | 18 ++++++++++++++++++
> include/linux/phy.h | 15 ++-------------
> 3 files changed, 21 insertions(+), 14 deletions(-)
> create mode 100644 drivers/net/phy/mdio_devres.c
This would likely require an update to the MAINTAINERS file for this new
file to be picked up by the correct entry.
--
Florian
next prev parent reply other threads:[~2020-06-22 23:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 10:00 [Intel-wired-lan] [PATCH 00/11] net: improve devres helpers Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 01/11] net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init() Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 02/11] net: ethernet: ixgbe: don't call devm_mdiobus_free() Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 03/11] net: devres: relax devm_register_netdev() Bartosz Golaszewski
2020-06-22 22:49 ` Jakub Kicinski
2020-06-23 9:12 ` Bartosz Golaszewski
2020-06-23 20:16 ` Jakub Kicinski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 04/11] net: devres: rename the release callback of devm_register_netdev() Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 05/11] Documentation: devres: add missing mdio helper Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 06/11] phy: un-inline devm_mdiobus_register() Bartosz Golaszewski
2020-06-22 23:55 ` Florian Fainelli [this message]
2020-06-25 9:16 ` Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 07/11] phy: mdio: add kerneldoc for __devm_mdiobus_register() Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 08/11] net: phy: don't abuse devres in devm_mdiobus_register() Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 09/11] of: mdio: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 10/11] of: mdio: provide devm_of_mdiobus_register() Bartosz Golaszewski
2020-06-22 10:00 ` [Intel-wired-lan] [PATCH 11/11] net: ethernet: mtk-star-emac: use devm_of_mdiobus_register() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e761f3-6607-d209-61df-535330f50db3@gmail.com \
--to=f.fainelli@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox