From: Gavin Lambert <intel@mirality.co.nz>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [e1000e] Linux 4.9: unable to send packets after link recovery with patched driver
Date: Fri, 19 Jul 2019 12:40:10 +1200 [thread overview]
Message-ID: <3a63201c552a9cb6a9737fec92bc1264@mirality.co.nz> (raw)
In-Reply-To: <d3118220-e599-44cd-5ed6-43259c5fc2c2@intel.com>
On 2019-07-18 20:24, Neftin, Sasha wrote:
> Please, refer to the commit def4ec6dce393e2136b62a05712f35a7fa5f5e56
> on the Jeff Kirsher's next-queue:
> https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git/commit/drivers/net/ethernet/intel/e1000e?id=def4ec6dce393e2136b62a05712f35a7fa5f5e56
>
> We are working to push this patch to upstream.
Thanks, that does sound identical to my symptoms.
However I tried applying this patch to my driver in 4.9 and it does not
resolve the problem.
Are some additional patches required as well?
FWIW, I added some extra logging around the new code. I can confirm
that it does execute on link regain but doesn't actually enter the loop
in my problem case. The pcim_state is 0x00080083 at the time. So the
e1000_phy_hw_reset is never actually called. If I try changing it to
call that unconditionally, then it can't successfully establish a link
in the first place.
next prev parent reply other threads:[~2019-07-19 0:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 6:50 [Intel-wired-lan] [e1000e] Linux 4.9: unable to send packets after link recovery with patched driver Gavin Lambert
2019-07-12 3:23 ` Gavin Lambert
2019-07-18 8:06 ` Gavin Lambert
2019-07-18 8:22 ` Paul Menzel
2019-07-18 8:24 ` Neftin, Sasha
2019-07-19 0:40 ` Gavin Lambert [this message]
2019-07-19 1:02 ` Gavin Lambert
2019-08-20 2:15 ` Gavin Lambert
2019-09-03 7:56 ` Gavin Lambert
2019-09-03 8:35 ` Paul Menzel
2019-09-03 9:20 ` Greg Kroah-Hartman
2019-09-03 9:28 ` Winkler, Tomas
2019-09-03 9:39 ` Paul Menzel
2019-09-03 11:00 ` Gavin Lambert
2019-09-04 10:06 ` Winkler, Tomas
2019-09-04 11:08 ` Gavin Lambert
2019-09-04 12:31 ` Lifshits, Vitaly
2019-09-05 3:59 ` Gavin Lambert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a63201c552a9cb6a9737fec92bc1264@mirality.co.nz \
--to=intel@mirality.co.nz \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox