Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Lifshits <vitaly.lifshits@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake
Date: Sat, 25 Jan 2020 14:22:27 +0200	[thread overview]
Message-ID: <3b5bb66d-949e-e190-56c1-c067a2f3bb9b@intel.com> (raw)
In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B971CC4E7@ORSMSX103.amr.corp.intel.com>

On 1/25/2020 04:45, Brown, Aaron F wrote:
>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>> Vitaly Lifshits
>> Sent: Sunday, January 19, 2020 2:08 AM
>> To: intel-wired-lan at lists.osuosl.org
>> Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device
>> Id of Tiger Lake
>>
>> Added support to 0x15F5 Device ID which is part of Intel Tiger Lake
>> Platforms. This patch follows commit:
>> 776f5d57ee ("e1000e: Add support for Tiger Lake").
>>
>> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/hw.h     | 1 +
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h
>> b/drivers/net/ethernet/intel/e1000e/hw.h
>> index f556163481cb..b85210ef31d9 100644
>> --- a/drivers/net/ethernet/intel/e1000e/hw.h
>> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
>> @@ -97,6 +97,7 @@ struct e1000_hw;
>>   #define E1000_DEV_ID_PCH_TGP_I219_LM14		0x15F9
>>   #define E1000_DEV_ID_PCH_TGP_I219_V14		0x15FA
>>   #define E1000_DEV_ID_PCH_TGP_I219_LM15		0x15F4
>> +#define E1000_DEV_ID_PCH_TGP_I219_V15		0x15F5
> <snip>
> 
> Something seems to be missing.  After building and booting to the kernel with this patch included I do not see the 15f5 device from modinfo:
> u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5
> u1519:[1]/usr/src/kernels/next-queue>
> 

If I understand your test correctly, I think you should run:
 > modinfo e1000e | grep -i 15f5

Since the patch is to e1000e module and not igc.

  reply	other threads:[~2020-01-25 12:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-19 10:08 [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake Vitaly Lifshits
2020-01-22  6:23 ` Neftin, Sasha
2020-01-25  2:45 ` Brown, Aaron F
2020-01-25 12:22   ` Vitaly Lifshits [this message]
2020-01-27 21:29     ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b5bb66d-949e-e190-56c1-c067a2f3bb9b@intel.com \
    --to=vitaly.lifshits@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox