From: Sasha Neftin <sasha.neftin@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-queue v1] igc: Use num_tx_queues when iterating over tx_ring queue
Date: Thu, 22 Jul 2021 08:02:20 +0300 [thread overview]
Message-ID: <3b92e1b7-5187-b180-04fc-b3363d2d212f@intel.com> (raw)
In-Reply-To: <20210722003403.69289-1-vinicius.gomes@intel.com>
On 7/22/2021 03:34, Vinicius Costa Gomes wrote:
> From: "Nishioka, Toshiki" <toshiki.nishioka@intel.com>
>
> Use num_tx_queues rather than the IGC_MAX_TX_QUEUES fixed number 4 when
> iterating over tx_ring queue since instantiated queue count could be
> less than 4 where on-line cpu count is less than 4.
>
> Fixes: ec50a9d437f0 ("igc: Add support for taprio offloading")
> Signed-off-by: Toshiki Nishioka <toshiki.nishioka@intel.com>
> Tested-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index e29aadbc6744..2b3b741f816c 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -5489,7 +5489,7 @@ static bool validate_schedule(struct igc_adapter *adapter,
> if (e->command != TC_TAPRIO_CMD_SET_GATES)
> return false;
>
> - for (i = 0; i < IGC_MAX_TX_QUEUES; i++) {
> + for (i = 0; i < adapter->num_tx_queues; i++) {
> if (e->gate_mask & BIT(i))
> queue_uses[i]++;
>
> @@ -5546,7 +5546,7 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter,
>
> end_time += e->interval;
>
> - for (i = 0; i < IGC_MAX_TX_QUEUES; i++) {
> + for (i = 0; i < adapter->num_tx_queues; i++) {
> struct igc_ring *ring = adapter->tx_ring[i];
>
> if (!(e->gate_mask & BIT(i)))
>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
prev parent reply other threads:[~2021-07-22 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 0:34 [Intel-wired-lan] [PATCH net-queue v1] igc: Use num_tx_queues when iterating over tx_ring queue Vinicius Costa Gomes
2021-07-22 5:02 ` Sasha Neftin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b92e1b7-5187-b180-04fc-b3363d2d212f@intel.com \
--to=sasha.neftin@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox