From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CAF2EA7943 for ; Wed, 4 Feb 2026 22:52:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AD90960E17; Wed, 4 Feb 2026 22:52:46 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id pyq0vXgwAEGt; Wed, 4 Feb 2026 22:52:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9903860E19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1770245564; bh=EJoZknlyXtAyOLBNPLzRyCmW6dHCkdD5Zvl96QPeKQE=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=D5/bWdSWS/GmmP47KKgRW+t3c86CIoXu3kJFKMstNkgL7jEBmMi+YY8nRRwV1ILLf xQnSFPVfenJYS7+j5/5vzVsI/RelQndBcwck8RWD5Ln9JdFJh6vOKLNgxswywhHcjH cQhaZEBk4B2AW49Zh8cDBkXl9fkcbiRoBgLapDKxMQGih6cBGuRpyeebs6PgCGkcmw WAi2D3pni/lSaj2F4vG7QJ92hCD6Bgt0vBf/6FHIqmfble4OCTMqjHfnzf+DEHxB2h jYi4zH4/peZ2xOoQhmnDwG3R+bGzSoFOX145I6WIIailsIWdozfze3fGfT0AQZWDXM ZJ+1D7FzQZv4Q== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 9903860E19; Wed, 4 Feb 2026 22:52:44 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id D94B4173 for ; Wed, 4 Feb 2026 22:52:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C732E40275 for ; Wed, 4 Feb 2026 22:52:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id rNP0Ut_AzBdS for ; Wed, 4 Feb 2026 22:52:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:41d0:203:375::ae; helo=out-174.mta1.migadu.com; envelope-from=martin.lau@linux.dev; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4C5E440D75 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4C5E440D75 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [IPv6:2001:41d0:203:375::ae]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4C5E440D75 for ; Wed, 4 Feb 2026 22:52:40 +0000 (UTC) Message-ID: <3df436d9-5671-410c-ad0d-67d9fa540330@linux.dev> Date: Wed, 4 Feb 2026 14:52:19 -0800 MIME-Version: 1.0 To: Larysa Zaremba Cc: Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Simon Horman , Shuah Khan , Alexander Lobakin , Maciej Fijalkowski , "Bastien Curutchet (eBPF Foundation)" , Tushar Vyavahare , Jason Xing , =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= , Eelco Chaudron , Lorenzo Bianconi , Toke Hoiland-Jorgensen , imx@lists.linux.dev, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kselftest@vger.kernel.org, Aleksandr Loktionov References: <20260203105417.2302672-1-larysa.zaremba@intel.com> <20260203105417.2302672-2-larysa.zaremba@intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20260203105417.2302672-2-larysa.zaremba@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770245551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EJoZknlyXtAyOLBNPLzRyCmW6dHCkdD5Zvl96QPeKQE=; b=HtDRI+Qz+/WPhHk0OHCPF1aB7QuWSOfsCq2Bf7mxIuipnkr7S2QqYvlCBTNUb0iu+hoHUt /rat+5i/6Wcn6GPCTJXfdG4OWi8GiroFMZUBIyqZVEzvhDncDL+YFzwW54xpdXPJ7W6loT VyERfVRddW5EmiuIN3/tBwu/wn6JOGk= X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=linux.dev X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=HtDRI+Qz Subject: Re: [Intel-wired-lan] [PATCH bpf 1/6] xdp: produce a warning when calculated tailroom is negative X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 2/3/26 2:53 AM, Larysa Zaremba wrote: > The issue can be fixed in all in-tree drivers, but we cannot just trust OOT > drivers to not do this. Therefore, make tailroom a signed int and produce a > warning when it is negative to prevent such mistakes in the future. > > Fixes: bf25146a5595 ("bpf: add frags support to the bpf_xdp_adjust_tail() API") > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Larysa Zaremba > --- > net/core/filter.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 616e0520a0bb..9715d957e3c5 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -4149,12 +4149,13 @@ static int bpf_xdp_frags_increase_tail(struct xdp_buff *xdp, int offset) > struct skb_shared_info *sinfo = xdp_get_shared_info_from_buff(xdp); > skb_frag_t *frag = &sinfo->frags[sinfo->nr_frags - 1]; > struct xdp_rxq_info *rxq = xdp->rxq; > - unsigned int tailroom; > + int tailroom; > > if (!rxq->frag_size || rxq->frag_size > xdp->frame_sz) > return -EOPNOTSUPP; > > tailroom = rxq->frag_size - skb_frag_size(frag) - skb_frag_off(frag); > + WARN_ON_ONCE(tailroom < 0); > if (unlikely(offset > tailroom)) > return -EINVAL; Acked-by: Martin KaFai Lau