From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Vitaly Lifshits <vitaly.lifshits@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Nir Efrati <nir.efrati@intel.com>,
Nikolay Mushayev <nikolay.mushayev@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems
Date: Wed, 3 Jan 2024 15:52:56 -0800 [thread overview]
Message-ID: <3ee242a3-4fc7-61d0-e6d7-7e56f389e2b4@intel.com> (raw)
In-Reply-To: <20231227103312.182542-1-vitaly.lifshits@intel.com>
On 12/27/2023 2:33 AM, Vitaly Lifshits wrote:
> On some Meteor Lake systems accessing the PHY via the MDIO interface may
> result in an MDI error. This issue happens sporadically and in most cases
> a second access to the PHY via the MDIO interface results in success.
>
> As a workaround, introduce a retry counter which is set to 3 on Meteor
> Lake systems. The driver will only return an error if 3 consecutive PHY
> access attempts fail. The retry mechanism is disabled in specific flows,
> where MDI errors are expected.
>
> Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake")
> Suggested-by: Nikolay Mushayev <nikolay.mushayev@intel.com>
> Co-developed-by: Nir Efrati <nir.efrati@intel.com>
> Signed-off-by: Nir Efrati <nir.efrati@intel.com>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> ---
> v3: rebase to dev-queue branch
> v2: fix checkpatch errors
> v1: initial version
> ---
> drivers/net/ethernet/intel/e1000e/hw.h | 2 +
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 33 ++++
> drivers/net/ethernet/intel/e1000e/phy.c | 186 ++++++++++++--------
> drivers/net/ethernet/intel/e1000e/phy.h | 2 +
> 4 files changed, 151 insertions(+), 72 deletions(-)
This patch conflicts with your other patch [1]. In these situations
please either send the patches together as a series or wait until the
first is applied before sending the other. I've applied the other patch;
please rebase and re-send this.
Thanks,
Tony
[1]
https://lore.kernel.org/intel-wired-lan/20231227103154.177094-1-vitaly.lifshits@intel.com/
prev parent reply other threads:[~2024-01-03 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 10:33 [Intel-wired-lan] [PATCH iwl-net v3 1/1] e1000e: Workaround for sporadic MDI error on Meteor Lake systems Vitaly Lifshits
2024-01-03 23:52 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee242a3-4fc7-61d0-e6d7-7e56f389e2b4@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=nikolay.mushayev@intel.com \
--cc=nir.efrati@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox