From: Ivan Vecera <ivecera@redhat.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Mateusz Palczewski <mateusz.palczewski@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value
Date: Thu, 19 Oct 2023 18:35:19 +0200 [thread overview]
Message-ID: <3f12a532-a0f9-4a7e-bfda-c85b539b81d0@redhat.com> (raw)
In-Reply-To: <20231019091408.GA2100445@kernel.org>
On 19. 10. 23 11:15, Simon Horman wrote:
> On Wed, Oct 18, 2023 at 01:26:20PM +0200, Ivan Vecera wrote:
>> Commit c87c938f62d8f1 ("i40e: Add VF VLAN pruning") added new
>> PF flag I40E_FLAG_VF_VLAN_PRUNING but its value collides with
>> existing I40E_FLAG_TOTAL_PORT_SHUTDOWN_ENABLED flag.
>>
>> Move the affected flag at the end of the flags and fix its value.
>>
>> Cc: Mateusz Palczewski <mateusz.palczewski@intel.com>
>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>
> Hi Ivan,
>
> I agree with the correctness of this patch and that it was
> introduced by the cited commit.
>
> However, I do wonder if, as a fix for 'net':
>
> 1) The patch description could include some discussion of
> what problem is resolved, and, ideally, how I user might
> get into such a situation.
>
> 2) The following fixes tag is appropriate.
>
> Fixes: c87c938f62d8 ("i40e: Add VF VLAN pruning")
>
Ahh, thanks Simon! I forgot to add Fixes: tag.
Will fix it by v2 and add the reproducer.
Thanks,
Ivan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2023-10-19 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 11:26 [Intel-wired-lan] [PATCH net] i40e: Fix I40E_FLAG_VF_VLAN_PRUNING value Ivan Vecera
2023-10-18 12:30 ` Przemek Kitszel
2023-10-19 19:20 ` Jacob Keller
2023-10-19 19:48 ` Ivan Vecera
2023-10-19 22:34 ` Jacob Keller
2023-10-19 9:15 ` Simon Horman
2023-10-19 16:35 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f12a532-a0f9-4a7e-bfda-c85b539b81d0@redhat.com \
--to=ivecera@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox