From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 290F2C4167B for ; Wed, 6 Dec 2023 08:22:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BA4CF8206D; Wed, 6 Dec 2023 08:22:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org BA4CF8206D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1701850949; bh=arnf9V8A46zpxOfOcx0+e+NDNciEwBjHQEpy+kjFBZg=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=cXenZwtzU1IBTJGJUniXexQ3rUxMP3Bgyvessx5S/a06cOcGrLnsE3sFaoF5dlN7b ZFMaOkp5/WRNxuPOhOnKW0w6nJwNuxpAzNSOJgiKGApVHQrywMsZocvO67fn65iSQn wBMqA3+N67uyghd7ixpwZCSmTSmNrT8goxHhQr0cKLEJAQqMBURoZr+jqMs+cRZWOT 0KKL0kgzUT2qTNEgjTZZjcN1SCqZUG01Is31pbpTYrTmed/gprkYyXYwEq326GrENu w2t5sfvT0gUobMSbn7DXSfaMYPrdTB6yIfVjESK5vwOpIs1dshqRI8YhQveDFS5lRu 2hwv43/fztIFg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jjE2hNItlEYK; Wed, 6 Dec 2023 08:22:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id C81AD82741; Wed, 6 Dec 2023 08:22:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C81AD82741 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 24DB81BF32A for ; Wed, 6 Dec 2023 08:22:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 04CAA81F30 for ; Wed, 6 Dec 2023 08:22:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 04CAA81F30 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s5LscXbZFkuf for ; Wed, 6 Dec 2023 08:22:26 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by smtp1.osuosl.org (Postfix) with ESMTPS id 209A88206D for ; Wed, 6 Dec 2023 08:22:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 209A88206D X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="7376355" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="7376355" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 00:22:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="747522206" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="747522206" Received: from naamamex-mobl.ger.corp.intel.com (HELO [10.12.48.131]) ([10.12.48.131]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 00:22:23 -0800 Message-ID: <41a1392c-0e82-4906-8744-fd527d18f6aa@linux.intel.com> Date: Wed, 6 Dec 2023 10:22:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Jesse Brandeburg , intel-wired-lan@lists.osuosl.org References: <20231121211921.19834-1-jesse.brandeburg@intel.com> <20231121211921.19834-11-jesse.brandeburg@intel.com> From: "naamax.meir" In-Reply-To: <20231121211921.19834-11-jesse.brandeburg@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701850946; x=1733386946; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1jRA3HwtbtIDHZrW+rnVUKgEuSqeWhnsqzgAyyeUTjE=; b=UjQK7Ml86sndWpvmsU/bmVF2CuedtH2gwOLlMZrEH4zHx57IgVYzuiqH y9XJoM+YHc2duGVIbIfRR/rL4AIAz1IaH+MPDg15nDw/Jx1PtgiFhdxHG cJ/OtvrCdJMQLKPsXsXbk/wprMTUuF0vnCwVESw0Hb6zgFE+zmXBVEk9y u9VfXwpbsNWYIaB70YHPbpcxm7eAWsvT0+8i9ep2gVwKgs/dY0PoSDoGu 4vRaJY4XybTO2qFYJt0Akt1VFury46Evp66u1JMgLsxCyXs+K3LkGBuLB N/MDQ2ePRvMQIU1Gn6w0841PKpmfeIQj8TA9Z3vvgxwXnroDOT+esDQZo Q==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=UjQK7Ml8 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 10/13] igc: field get conversion X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Lawall , netdev@vger.kernel.org, Marcin Szycik Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 11/21/2023 23:19, Jesse Brandeburg wrote: > Refactor the igc driver to use FIELD_GET() for mask and shift reads, > which reduces lines of code and adds clarity of intent. > > This code was generated by the following coccinelle/spatch script and > then manually repaired in a later patch. > > @get@ > constant shift,mask; > expression a; > @@ > -((a & mask) >> shift) > +FIELD_GET(mask, a) > > and applied via: > spatch --sp-file field_prep.cocci --in-place --dir \ > drivers/net/ethernet/intel/ > > Cc: Julia Lawall > Reviewed-by: Marcin Szycik > Signed-off-by: Jesse Brandeburg > --- > drivers/net/ethernet/intel/igc/igc_base.c | 6 ++---- > drivers/net/ethernet/intel/igc/igc_i225.c | 5 ++--- > drivers/net/ethernet/intel/igc/igc_main.c | 6 ++---- > drivers/net/ethernet/intel/igc/igc_phy.c | 4 ++-- > 4 files changed, 8 insertions(+), 13 deletions(-) Tested-by: Naama Meir _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan