Re: [Intel-wired-lan] [PATCH net-next v2 3/4] i40e: use int for i40e_status

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 11/30/2022 4:46 AM, Jan Sokolowski wrote:
> To prepare for removal of i40e_status, change the variables
> from i40e_status to int. This eases the transition when values
> are changed to return standard int error codes over enum i40e_status.
> 
> As such changes often also change variable orders, a cleanup
> is also applied here to make variables conform to RCT and
> some lines are also reformatted where applicable.

You missed one conversion:

drivers/net/ethernet/intel/i40e/i40e_common.c:1693:1: error: unknown 
type name 'i40e_status'
i40e_status i40e_aq_set_mac_loopback(struct i40e_hw *hw, bool ena_lpbk,


This is filled with checkpatch entries for: "CHECK: Alignment should 
match open parenthesis", please fix where applicable.

and one

"
CHECK: Please use a blank line after function/struct/union/enum declarations
#3113: FILE: drivers/net/ethernet/intel/i40e/i40e_hmc.h:190:
  }
+int i40e_add_sd_table_entry(struct i40e_hw *hw,
"

> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> ---

<snip>

> @@ -788,7 +788,7 @@ i40e_asq_send_command_atomic_exec(struct i40e_hw *hw,
>   				  struct i40e_asq_cmd_details *cmd_details,
>   				  bool is_atomic_context)
>   {
> -	i40e_status status = 0;
> +	int status = 0;

Missed this one for RCT

>   	struct i40e_dma_mem *dma_buff = NULL;
>   	struct i40e_asq_cmd_details *details;
>   	struct i40e_aq_desc *desc_on_ring;

<snip>

> @@ -3107,7 +3108,7 @@ static void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,
>   	u32 number, logical_id, phys_id;
>   	struct i40e_hw_capabilities *p;
>   	u16 id, ocp_cfg_word0;
> -	i40e_status status;
> +	int status;

Another one here

>   	u8 major_rev;
>   	u32 i = 0;
>   

<snip>

> @@ -15636,7 +15635,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	struct i40e_aq_get_phy_abilities_resp abilities;
>   #ifdef CONFIG_I40E_DCB
>   	enum i40e_get_fw_lldp_status_resp lldp_status;
> -	i40e_status status;
> +	int status;

This one needs reordering as well.

>   #endif /* CONFIG_I40E_DCB */
>   	struct i40e_pf *pf;
>   	struct i40e_hw *hw;
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan