From: =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= <bjorn.topel@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net 2/3] ixgbe: avoid premature Rx buffer reuse
Date: Tue, 25 Aug 2020 12:00:33 +0200 [thread overview]
Message-ID: <43f838aa-b12b-63d3-400b-ef92081b355d@intel.com> (raw)
In-Reply-To: <6356c0ddbdbd4f8fb4927f3ee96c4c33@baidu.com>
On 2020-08-25 11:55, Li,Rongqing wrote:
>
>
>> -----Original Message-----
>> From: Bj?rn T?pel [mailto:bjorn.topel at gmail.com]
>> Sent: Tuesday, August 25, 2020 5:16 PM
>> To: jeffrey.t.kirsher at intel.com; intel-wired-lan at lists.osuosl.org
>> Cc: Bj?rn T?pel <bjorn.topel@intel.com>; magnus.karlsson at intel.com;
>> magnus.karlsson at gmail.com; netdev at vger.kernel.org;
>> maciej.fijalkowski at intel.com; piotr.raczynski at intel.com;
>> maciej.machnikowski at intel.com; Li,Rongqing <lirongqing@baidu.com>
>> Subject: [PATCH net 2/3] ixgbe: avoid premature Rx buffer reuse
>>
>> From: Bj?rn T?pel <bjorn.topel@intel.com>
>>
>> The page recycle code, incorrectly, relied on that a page fragment could not be
>> freed inside xdp_do_redirect(). This assumption leads to that page fragments
>> that are used by the stack/XDP redirect can be reused and overwritten.
>>
>> To avoid this, store the page count prior invoking xdp_do_redirect().
>>
>> Fixes: 6453073987ba ("ixgbe: add initial support for xdp redirect")
>> Signed-off-by: Bj?rn T?pel <bjorn.topel@intel.com>
>
> Reported-and-analyzed-by: Li RongQing <lirongqing@baidu.com>
>
Thanks Li! I should have added that. Intel-folks, please make sure Li's
tags for ixgbe/ice are added.
Bj?rn
> Thanks
>
> -Li
>
next prev parent reply other threads:[~2020-08-25 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 9:16 [Intel-wired-lan] [PATCH net 0/3] Avoid premature Rx buffer reuse for XDP_REDIRECT =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-08-25 9:16 ` [Intel-wired-lan] [PATCH net 1/3] i40e: avoid premature Rx buffer reuse =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-08-25 11:13 ` Maciej Fijalkowski
2020-08-25 11:25 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-08-25 11:29 ` Maciej Fijalkowski
2020-08-25 11:37 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-08-25 9:16 ` [Intel-wired-lan] [PATCH net 2/3] ixgbe: " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-08-25 9:55 ` Li, Rongqing
2020-08-25 10:00 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?= [this message]
2020-08-25 9:16 ` [Intel-wired-lan] [PATCH net 3/3] ice: " =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-08-25 9:55 ` Li, Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43f838aa-b12b-63d3-400b-ef92081b355d@intel.com \
--to=bjorn.topel@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox