From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7D80CD5BD4 for ; Thu, 5 Sep 2024 16:17:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4887260A95; Thu, 5 Sep 2024 16:17:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id i30G8rKiswan; Thu, 5 Sep 2024 16:17:51 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9E41C60A8E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1725553071; bh=iaE5XqWoFR9AdfJpm9q1/ADqgtzDcMWaCwCzCaQbFu4=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=wJMrrNDbSptZibqrwNu1Dc4Jk7I2q5DdUJOFdGg6lZF6K5orm+lylFkYCHXuoC9fY tXdSQ9K4zupACOgn7rCtIdl/G0Ar6xMgZKnit8GO+da9gNFMKH4vm+wxswIVp2hGG4 DfB8B5lvZAYhSAQIUntD8cEXLFcxjL/S1k5LJWOWWjooq2A5Rq3EjZRiEcR0TE6hfb hGEyT72nIYue44yNOlPl5quP6NaD7zHP4vKgmdDqb/87Zqn/zLcAdH8zmoRNyc1Ylv +6m4Zt4Fe5nuTtXBdFuD4i007MGornYQhmWI+UiaZhKq47cdWdXBhaBQMCPao0DBA2 bSh3BgthTt2iA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 9E41C60A8E; Thu, 5 Sep 2024 16:17:51 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D3AAA1BF39D for ; Thu, 5 Sep 2024 16:17:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CCE3740200 for ; Thu, 5 Sep 2024 16:17:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6J1pwu2bu67O for ; Thu, 5 Sep 2024 16:17:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=pabeni@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D905C40169 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D905C40169 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id D905C40169 for ; Thu, 5 Sep 2024 16:17:48 +0000 (UTC) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-Iu-Tsu2cOqaLWlLLbbvcug-1; Thu, 05 Sep 2024 12:17:46 -0400 X-MC-Unique: Iu-Tsu2cOqaLWlLLbbvcug-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-374c294d841so847248f8f.1 for ; Thu, 05 Sep 2024 09:17:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725553065; x=1726157865; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iaE5XqWoFR9AdfJpm9q1/ADqgtzDcMWaCwCzCaQbFu4=; b=lQu3nf+zLQClcMEiVko+Av66M+aHBrHW85nRqBxDW9EFtJNvq/hTcpjIBuZEZBKFg3 FU8pxEmpUP48Xr6pQRst0CHUZvlDDtI/xhZ/3OFODTnXEQOGKVVs8tkbm+nFBy4hG3iU Mp7t553dFA6GRPqNZnWNvbcrpngs/aEx5qdTFY37gXaQ/j5DBXqiDNGventCdW5YFdKi y8X+ETXlL/SObu4V24JToKcWSndQDOyYPH31jFIOo4d1+Lb1uO/lyNMrGbamOR7Q0M/d kGAv4rQMpHV80vb34/prSEJ9QswpnhBGCHO7zYUMYnB9kmqL7GIrpd3w1llitgVVhlLS QwCw== X-Forwarded-Encrypted: i=1; AJvYcCWgvSyhxX+FgHZslN/ZLpX+VPGsEyPgUDKZsNDxG3MeZxxHM+69NpMfMwRgR07gJTTbz4k0tdNIdMptFF8NY6U=@lists.osuosl.org X-Gm-Message-State: AOJu0YypsTMCwV9xrVD7egnkP62gOGg5jp6QXQ9rHALmIMYzK7a268ZW +iuI/LONiawQrx94xMwjltwPClrOwLRlR/a72BSy6jgZuIBIQpmSjYI6Z90rSMFsJ82Ac2Q2y9h X31GF7MzS80VgyZe435+LFA7yq9yVnuM3jkuUU2kpK2oJ8B3SI6dt+q15CD+M8zbDtw8= X-Received: by 2002:adf:f7c8:0:b0:374:c512:87ce with SMTP id ffacd0b85a97d-374c5128a82mr12130911f8f.30.1725553065031; Thu, 05 Sep 2024 09:17:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvu/apiMAq4RvAl5wSKKN+12JGeZYYbO4xdhF9luYBHaFwsBjDjg3e4qWvyCzXP2gyQw0nog== X-Received: by 2002:adf:f7c8:0:b0:374:c512:87ce with SMTP id ffacd0b85a97d-374c5128a82mr12130890f8f.30.1725553064557; Thu, 05 Sep 2024 09:17:44 -0700 (PDT) Received: from [192.168.88.27] (146-241-55-250.dyn.eolo.it. [146.241.55.250]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ef7e109sm19554723f8f.67.2024.09.05.09.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 09:17:44 -0700 (PDT) Message-ID: <46484afd-7b50-465d-b763-0ac60201bd3d@redhat.com> Date: Thu, 5 Sep 2024 18:17:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jakub Kicinski References: <20240904180330.522b07c5@kernel.org> <20240905080502.3246e040@kernel.org> From: Paolo Abeni In-Reply-To: <20240905080502.3246e040@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725553067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iaE5XqWoFR9AdfJpm9q1/ADqgtzDcMWaCwCzCaQbFu4=; b=QankzAG5YXiX0tAxHM3aCiwo5QvmjnjdVyrH7WlSukHmP4ucTJafjH2A/r+6PnVFeJAkD/ dC0DzlCK1+I6yB17rkAdVM7BwRqvZqbmeo0tlucdvEL4VGClPLNB+rQl/s5lMGg6AzqxFW pbbyEWGX1G8SXkvUamNL6YxZm3txat4= X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QankzAG5 Subject: Re: [Intel-wired-lan] [PATCH v6 net-next 02/15] netlink: spec: add shaper YAML spec X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Pirko , netdev@vger.kernel.org, John Fastabend , Jamal Hadi Salim , edumazet@google.com, Madhu Chittim , anthony.l.nguyen@intel.com, Simon Horman , Sridhar Samudrala , Donald Hunter , intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, Sunil Kovvuri Goutham Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 9/5/24 17:05, Jakub Kicinski wrote: > On Thu, 5 Sep 2024 16:51:00 +0200 Paolo Abeni wrote: >> On 9/5/24 03:03, Jakub Kicinski wrote: >>> On Wed, 4 Sep 2024 15:53:34 +0200 Paolo Abeni wrote: >>>> + - >>>> + name: node >>>> + type: nest >>>> + nested-attributes: node-info >>>> + doc: | >>>> + Describes the node shaper for a @group operation. >>>> + Differently from @leaves and @shaper allow specifying >>>> + the shaper parent handle, too. >>> >>> Parent handle is inside node scope? Why are leaves outside and parent >>> inside? Both should be at the same scope, preferably main scope. >> >> The group() op receives as arguments, in the main scope: >> >> ifindex >> node >> leaves >> >> 'parent' is a nested attribute for 'node', exactly as 'handle'. We need >> to specify both to identify the 'node' itself (via the 'handle') and to >> specify where in the hierarchy the 'node' will be located (via the >> 'parent'). Do I read correctly that you would prefer: >> >> ifindex >> node_handle >> node_parent >> leaves > > I don't see example uses in the cover letter or the test so there's > a good chance I'm missing something, but... why node_parent? > The only thing you need to know about the parent is its handle, > so just "parent", right? > > Also why node_handle? Just "handle", and other attrs of the node can > live in the main scope. I added the 'node_' prefix in the list to stress that such attributes belong to the node. In the yaml/command line will be only 'handle', 'parent'. > Unless you have a strong reason to do this to simplify the code - > "from netlink perspective" it looks like unnecessary nesting. > The operation arguments describe the node, there's no need to nest > things in another layer. Ok, the code complexity should not change much. Side question: currently the node() operation allows specifying all the b/w related attributes for the 'node' shaper, should I keep them? (and move them in the main yaml scope) Thanks, Paolo