From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D5F3C19F2A for ; Thu, 11 Aug 2022 21:41:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 796C582FE4; Thu, 11 Aug 2022 21:41:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 796C582FE4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1660254118; bh=SAUepmg/SvRcy2MqEN7yaSv4LBxPY1sndo5m3r6dIbw=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Ti7qbYO4ooAD4JLyPFaaPoc/7x7s2qK8NNTTScFQJPVpvRJ+dbwIGL23dvkAexvSb +r83VZaIqVeUpARTAHGOeh0nCkJIc1IcOs33hT1597bBn1U/Gc9UYUolauHB4E8Leb 1rykl54sYwTe0klq6atKO+REXoJapN8GVkMIdghn4v20l7NQ1vCFR5rnubkhKkCuFR BAh101GVWAJiPDtsm5bdeGYIikyYXAyIX8INEQ/KHfaiRnUxAMCXvnAbnwyns/0RxU 3uWqqMc4ho85ByNBEfUML5BRgsUhSQy/VI3URGJxQxLBabm2OHl2VgjQI1L7CygFC9 YRUB1RL75PXBA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q5FoPvzxFXEy; Thu, 11 Aug 2022 21:41:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 7C67082FF9; Thu, 11 Aug 2022 21:41:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7C67082FF9 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 06EBB1BF215 for ; Thu, 11 Aug 2022 21:41:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CBCDE60BC7 for ; Thu, 11 Aug 2022 21:41:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CBCDE60BC7 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id koDh1I9Y45XL for ; Thu, 11 Aug 2022 21:41:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7C24260BB9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7C24260BB9 for ; Thu, 11 Aug 2022 21:41:54 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 600A061491; Thu, 11 Aug 2022 21:41:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 334E3C433D6; Thu, 11 Aug 2022 21:41:51 +0000 (UTC) From: James Hogan To: Vinicius Costa Gomes Date: Thu, 11 Aug 2022 22:41:48 +0100 Message-ID: <4759452.31r3eYUQgx@saruman> In-Reply-To: <20220811202524.78323-1-vinicius.gomes@intel.com> References: <20220811151342.19059-1-vinicius.gomes@intel.com> <20220811202524.78323-1-vinicius.gomes@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660254112; bh=sHLc73KXR0K1Nu0toL5g8k604GueGzA6AHIHEoqrmAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKcrpUtm5/KyTu5jd3Z8mzgNJjx3rqd4Z//uMXXc5qz1q2JGyTMBo+D9zjdHZVh3B ESB+tSIci7F7iVQmHJ5aQo06nMgSqkUMysFiHMIogi3+qXSNTDeCDTL3YE/OblaAis oV0BPaOD6wZ9Iumn4AaacvRCxGVL3mLb2RiE1mMOaCyYNgqvjW08blNbmWqhX+54PH YlfabiV86h6HiKxWp/uiZWuu+KcmlK+powNLWTagwOZ87FBOOCYvTYfZHC13Er9z+7 2ISkUSptpXLA0I6+H1VIPGmLNRB3RqB3ECBwnje1lIDXXd8NghBWEWimsYs5o1gVm5 DQVKKK0kdWriA== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EKcrpUtm Subject: Re: [Intel-wired-lan] [WIP v2] igc: fix deadlock caused by taking RTNL in RPM resume path X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , netdev@vger.kernel.org, Jesse Brandeburg , Aleksandr Loktionov , intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thursday, 11 August 2022 21:25:24 BST Vinicius Costa Gomes wrote: > It was reported a RTNL deadlock in the igc driver that was causing > problems during suspend/resume. > > The solution is similar to commit ac8c58f5b535 ("igb: fix deadlock > caused by taking RTNL in RPM resume path"). > > Reported-by: James Hogan > Signed-off-by: Vinicius Costa Gomes > --- > Sorry for the noise earlier, my kernel config didn't have runtime PM > enabled. Thanks for looking into this. This is identical to the patch I've been running for the last week. The deadlock is avoided, however I now occasionally see an assertion from netif_set_real_num_tx_queues due to the lock not being taken in some cases via the runtime_resume path, and a suspicious rcu_dereference_protected() warning (presumably due to the same issue of the lock not being taken). See here for details: https://lore.kernel.org/netdev/4765029.31r3eYUQgx@saruman/ Cheers James _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan