Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Kubiak, Michal" <michal.kubiak@intel.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>
Cc: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
	"Tantilov, Emil S" <emil.s.tantilov@intel.com>,
	"Zaremba, Larysa" <larysa.zaremba@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Hay, Joshua A" <joshua.a.hay@intel.com>,
	"Lobakin, Aleksander" <aleksander.lobakin@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"Brady, Alan" <alan.brady@intel.com>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR
Date: Wed, 13 Dec 2023 15:06:09 -0800	[thread overview]
Message-ID: <4f2559d3-06f0-71c4-e34d-073f2bf84fe4@intel.com> (raw)
In-Reply-To: <BL3PR11MB643539AEA523C7427BD255F7C68DA@BL3PR11MB6435.namprd11.prod.outlook.com>



On 12/13/2023 2:22 PM, Nguyen, Anthony L wrote:
> 
> 
>> -----Original Message-----
>> From: Kubiak, Michal <michal.kubiak@intel.com>
>> Sent: Wednesday, December 13, 2023 5:51 AM
>>
>> On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal Kubiak wrote:
>>> On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote:
>>>> Dear Michal, dear Joshua,
>>>>
>>>>
>>>> Thank you for your patch.
>>>>
>>>> On 12/12/23 15:55, Michal Kubiak wrote:
>>>>> From: Joshua Hay <joshua.a.hay@intel.com>
>>>>>
>>>>> Tell hardware to writeback completed descriptors even when
>>>>> interrupts
>>>>
>>>> Should you resend, the verb is spelled with a space: write back.
>>>
>>> Sure, I will fix it.
>>
>> Hi Tony,
>>
>> Could you please add a space ("writeback" -> "write back") when taking the
>> patch to your tree?
> 
> Yep, I can do that.

Actually, looks like you missed updating kdocs

drivers/net/ethernet/intel/idpf/idpf_txrx.h:508: warning: Function 
parameter or member 'dyn_ctl_intena_msk_m' not described in 'idpf_intr_reg'
drivers/net/ethernet/intel/idpf/idpf_txrx.h:508: warning: Function 
parameter or member 'dyn_ctl_wb_on_itr_m' not described in 'idpf_intr_reg'
drivers/net/ethernet/intel/idpf/idpf_txrx.h:561: warning: Function 
parameter or member 'wb_on_itr' not described in 'idpf_q_vector'

> Thanks,
> Tony
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  reply	other threads:[~2023-12-13 23:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 14:55 [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR Michal Kubiak
2023-12-12 16:50 ` Paul Menzel
2023-12-13 13:23   ` Michal Kubiak
2023-12-13 13:51     ` Michal Kubiak
2023-12-13 22:22       ` Nguyen, Anthony L
2023-12-13 23:06         ` Tony Nguyen [this message]
2023-12-15 17:27           ` Michal Kubiak
2023-12-14 12:59     ` Paul Menzel
2023-12-15 17:32       ` Michal Kubiak
2023-12-15 18:01 ` Brett Creeley
2023-12-15 19:04   ` Michal Kubiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f2559d3-06f0-71c4-e34d-073f2bf84fe4@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=alan.brady@intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=joshua.a.hay@intel.com \
    --cc=larysa.zaremba@intel.com \
    --cc=maciej.fijalkowski@intel.com \
    --cc=michal.kubiak@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox