From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EAB5C05027 for ; Mon, 23 Jan 2023 23:01:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E39A781FF4; Mon, 23 Jan 2023 23:01:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E39A781FF4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674514903; bh=BI8QpBcbUSSqBvL7rsJSNppumW7fN94BbLHXzALfQig=; h=From:To:In-reply-to:References:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=xlVfSiWQMJX+8Gp8vPDfbQQGnIM9JqKGMDSEUpxOmi/sPh8kwJpbP7/rxoVqWsfw+ VJ+GjcAlL2jhBnXYVG7jXGHupmrkic9E1OHOTb2B1arwh9fP9RKsxZPsy7N8m5n0MK un/oThRPshr8W1BN4CIp4k8ThlHZVlR5N6ZWgdg+6xWb+2G646ifR7HBCSoVAeNFhA dA+r6ij6sKXyW/9QG+LQdNP1Oo2sd7MkKuwYGXsLwMccH9SikkKhs8DlhV5q3r5hpr 45JLOVmFPL71XgA5KEo3N082f6LxdkYW/EJPqWp7w9exEmc09D9THtGkDAEXfeSAr3 NdMu0nbJ/SUhg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KWvYFlX8u-2n; Mon, 23 Jan 2023 23:01:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id E7AA281FFE; Mon, 23 Jan 2023 23:01:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E7AA281FFE Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 22DEC1BF3AE for ; Mon, 23 Jan 2023 23:01:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 07E0A81FFE for ; Mon, 23 Jan 2023 23:01:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 07E0A81FFE X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id woWoVKxSfdBp for ; Mon, 23 Jan 2023 23:01:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C757A81FF4 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by smtp1.osuosl.org (Postfix) with ESMTPS id C757A81FF4 for ; Mon, 23 Jan 2023 23:01:40 +0000 (UTC) Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6A50E3F761 for ; Mon, 23 Jan 2023 23:01:35 +0000 (UTC) Received: by mail-pl1-f200.google.com with SMTP id y8-20020a170902b48800b00192a600df83so7970447plr.15 for ; Mon, 23 Jan 2023 15:01:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:content-transfer-encoding:content-id:mime-version :comments:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ws4I49gzal9OMpseAqlgTMxeS+K4PzsbLrV3ypXSgOQ=; b=rXfMc64kvdGnqHkVmSbD27Aexal8Bk9a7g4E57wCyUNw2u2JP0vj57VcWl0ATib67d AcJ+RPjt3Uc7hJeO6h/GZ/HeLHRaTeL8iknp4CBo+p9yCEe5dHLmUabEUOKYFfMm1Ti0 s6BlEgU4TBJ9Q11CMsGOxy89Z+WfkEnOHeE+r4ZYos6/rn/B7XuJMiQiJ2FhL9ypG0JL 3UNtrnc3JyZ2xDrzVDlN6/kKgP3ttvQmvHjAHdlczfDP+cipv11ELYLH2F9xBDhzG2Qq 398hMXBu+mw+rxpJp2W8FaW8i4tEWYUz9DADrHfatu8Zs8Pg2sTY5VJhtvTRJvtCHxJ8 i6lw== X-Gm-Message-State: AFqh2kqrzQb5EUkhgCWiTemhIV+pS2uI1HurSWPY7N7GJPPxL7wWvoNo 2Ot+Qmz0sirD476y8+TjW6ijYWcCY3ts1oEVtRHLkoZOuTlKzi8tWJYaxdKFIwAeGFrOvvhJEfP yATRd65Vx+4tU/B6eitFWjO7q13j9yguu/oPhol1uBgoguq0= X-Received: by 2002:a62:ab02:0:b0:58d:982a:f1ed with SMTP id p2-20020a62ab02000000b0058d982af1edmr24276300pff.27.1674514894086; Mon, 23 Jan 2023 15:01:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXv06FZ22qYDSbiHlRRzdN+ym7mY/jj4yLHKaDeEBtmszT7tu35ck+5fnK0SVdJqtyl59pVEFw== X-Received: by 2002:a62:ab02:0:b0:58d:982a:f1ed with SMTP id p2-20020a62ab02000000b0058d982af1edmr24276280pff.27.1674514893770; Mon, 23 Jan 2023 15:01:33 -0800 (PST) Received: from famine.localdomain ([50.125.80.253]) by smtp.gmail.com with ESMTPSA id w1-20020aa79541000000b00580fb018e4bsm96558pfq.211.2023.01.23.15.01.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2023 15:01:33 -0800 (PST) Received: by famine.localdomain (Postfix, from userid 1000) id D1F24604E3; Mon, 23 Jan 2023 15:01:32 -0800 (PST) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id C37019FB5C; Mon, 23 Jan 2023 15:01:32 -0800 (PST) From: Jay Vosburgh To: Leon Romanovsky In-reply-to: References: Comments: In-reply-to Leon Romanovsky message dated "Mon, 23 Jan 2023 16:00:22 +0200." X-Mailer: MH-E 8.6+git; nmh 1.6; Emacs 29.0.50 MIME-Version: 1.0 Content-ID: <5063.1674514892.1@famine> Date: Mon, 23 Jan 2023 15:01:32 -0800 Message-ID: <5064.1674514892@famine> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1674514895; bh=ws4I49gzal9OMpseAqlgTMxeS+K4PzsbLrV3ypXSgOQ=; h=From:To:cc:Subject:In-reply-to:References:MIME-Version: Content-Type:Date:Message-ID; b=Q4xmO8ukmC8AAHgsAhD41RKYP7PgXeJ+aiJuFbPIMm+MEnPQZ4f6L5yASzXLqb83s 0ooo2kDgxaW6bBu/Z+CNDgrRn2XUSkkttxnszZ2QwyVmit0p/uy0Ob9cMO+LfzrySC S3OuA90sf3KuDkYXh5gAX3l+D/AQuVBn9oMGTH/o3o3jTZj9RwaI9qMlQl/qJvwh67 Jogc0xw1WDjjk041PGNb/XEBEpcGqpihPSnhpVwHlNBtbQnaBf6DxfLH8CSr+ayyoc vWOVOu/CB0vc5dxAC6z9XxmjCamicYwOr2O2h0eAGw+LsHMgatzSJgqJXG3olYd8tH Ij4qQSALrMO7Q== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=Q4xmO8uk Subject: Re: [Intel-wired-lan] [PATCH net-next 09/10] bonding: fill IPsec state validation failure reason X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steffen Klassert , Paolo Abeni , Ayush Sawal , Herbert Xu , Eric Dumazet , Jonathan Corbet , Tony Nguyen , netdev@vger.kernel.org, linux-doc@vger.kernel.org, Jesse Brandeburg , Saeed Mahameed , oss-drivers@corigine.com, Veaceslav Falico , Raju Rangoju , Simon Horman , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, Leon Romanovsky , "David S . Miller" , Andy Gospodarek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Leon Romanovsky wrote: >From: Leon Romanovsky > >Rely on extack to return failure reason. > >Signed-off-by: Leon Romanovsky >Signed-off-by: Leon Romanovsky >--- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index 686b2a6fd674..00646aa315c3 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -444,7 +444,7 @@ static int bond_ipsec_add_sa(struct xfrm_state *xs, > if (!slave->dev->xfrmdev_ops || > !slave->dev->xfrmdev_ops->xdo_dev_state_add || > netif_is_bond_master(slave->dev)) { >- slave_warn(bond_dev, slave->dev, "Slave does not support ipsec offload\n"); >+ NL_SET_ERR_MSG_MOD(extack, "Slave does not support ipsec offload"); > rcu_read_unlock(); > return -EINVAL; > } Why only this one, and not include the other similar slave_warn() calls in the bond_ipsec_* functions? That would seem to make some failures show up in dmesg, and others returned to the caller via extack. -J --- -Jay Vosburgh, jay.vosburgh@canonical.com _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan