From: Yonghong Song <yhs@meta.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: mst@redhat.com, vladimir.oltean@nxp.com, ast@kernel.org,
edumazet@google.com, anthony.l.nguyen@intel.com,
daniel@iogearbox.net, andrii@kernel.org,
intel-wired-lan@lists.osuosl.org, simon.horman@corigine.com,
kuba@kernel.org, pabeni@redhat.com, aelior@marvell.com,
hawk@kernel.org, christophe.jaillet@wanadoo.fr, memxor@gmail.com,
john@phrozen.org, bjorn@kernel.org, bpf@vger.kernel.org,
magnus.karlsson@intel.com, leon@kernel.org,
netdev@vger.kernel.org, toke@redhat.com, ecree.xilinx@gmail.com,
alardam@gmail.com, gospo@broadcom.com, saeedm@nvidia.com,
davem@davemloft.net, nbd@nbd.name
Subject: Re: [Intel-wired-lan] [RFC v2 bpf-next 3/7] xsk: add usage of XDP features flags
Date: Tue, 17 Jan 2023 15:37:58 -0800 [thread overview]
Message-ID: <51afcd71-8c19-8033-e21a-313b58f196ec@meta.com> (raw)
In-Reply-To: <Y8cwaVPDG/CN/JsU@lore-desk>
On 1/17/23 3:34 PM, Lorenzo Bianconi wrote:
>>
>>
>> On 1/14/23 7:54 AM, Lorenzo Bianconi wrote:
>>> From: Marek Majtyka <alardam@gmail.com>
>>>
>>> Change necessary condition check for XSK from ndo functions to
>>> xdp features flags.
>>>
>>> Signed-off-by: Marek Majtyka <alardam@gmail.com>
>>> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>> ---
>>> net/xdp/xsk_buff_pool.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
>>> index ed6c71826d31..2e6fa082142a 100644
>>> --- a/net/xdp/xsk_buff_pool.c
>>> +++ b/net/xdp/xsk_buff_pool.c
>>> @@ -178,8 +178,7 @@ int xp_assign_dev(struct xsk_buff_pool *pool,
>>> /* For copy-mode, we are done. */
>>> return 0;
>>> - if (!netdev->netdev_ops->ndo_bpf ||
>>> - !netdev->netdev_ops->ndo_xsk_wakeup) {
>>> + if ((netdev->xdp_features & NETDEV_XDP_ACT_ZC) != NETDEV_XDP_ACT_ZC) {
>>
>> Maybe:
>> if (!(netdev->xdp_features & NETDEV_XDP_ACT_ZC))
>
> I would say it not equivalent since:
>
> NETDEV_XDP_ACT_ZC = 0x5f
>
> and we want the device supports all the ZC requested features. Agree?
I missed the fact that NETDEV_XDP_ACT_ZC is not a BIT(...).
So your implementation is correct, sorry for the noise.
>
> Regards,
> Lorenzo
>
>> ?
>>
>>> err = -EOPNOTSUPP;
>>> goto err_unreg_pool;
>>> }
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-17 23:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 15:54 [Intel-wired-lan] [RFC v2 bpf-next 0/7] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 1/7] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 2/7] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-17 21:29 ` Niklas Söderlund
2023-01-17 21:58 ` Toke Høiland-Jørgensen
2023-01-17 22:05 ` Niklas Söderlund
2023-01-17 22:15 ` Toke Høiland-Jørgensen
2023-01-17 22:29 ` Niklas Söderlund
2023-01-17 22:42 ` Toke Høiland-Jørgensen
2023-01-17 23:45 ` Lorenzo Bianconi
2023-01-18 8:50 ` Niklas Söderlund
2023-01-18 9:38 ` Lorenzo Bianconi
2023-01-18 20:30 ` sdf
2023-01-19 14:23 ` Lorenzo Bianconi
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 3/7] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-17 22:07 ` Yonghong Song
2023-01-17 23:34 ` Lorenzo Bianconi
2023-01-17 23:37 ` Yonghong Song [this message]
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 4/7] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 5/7] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-18 0:58 ` Jakub Kicinski
2023-01-19 22:39 ` Lorenzo Bianconi
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 6/7] bpf: devmap: check XDP features in bpf_map_update_elem and __xdp_enqueue Lorenzo Bianconi
2023-01-14 15:54 ` [Intel-wired-lan] [RFC v2 bpf-next 7/7] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51afcd71-8c19-8033-e21a-313b58f196ec@meta.com \
--to=yhs@meta.com \
--cc=aelior@marvell.com \
--cc=alardam@gmail.com \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=lorenzo@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=memxor@gmail.com \
--cc=mst@redhat.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=toke@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox