From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bowers, AndrewX Date: Fri, 24 Jan 2020 23:17:09 +0000 Subject: [Intel-wired-lan] [PATCH S37 08/15] ice: fix and consolidate logging of NVM/firmware version information In-Reply-To: <20200122152041.41498-8-anthony.l.nguyen@intel.com> References: <20200122152041.41498-1-anthony.l.nguyen@intel.com> <20200122152041.41498-8-anthony.l.nguyen@intel.com> Message-ID: <51f5a00923514ba99d64fc21179d45c9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On > Behalf Of Tony Nguyen > Sent: Wednesday, January 22, 2020 7:21 AM > To: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH S37 08/15] ice: fix and consolidate logging > of NVM/firmware version information > > From: Bruce Allan > > Logging the firmware/NVM information during driver load is redundant since > that information is also available via ethtool. Move the functionality found in > ice_nvm_version_str() directly into ice_get_drvinfo() and remove calling the > former and logging that info during driver probe. This also gets rid of a bug in > ice_nvm_version_str() where it returns a pointer to a buffer which is free'ed > when that function exits. > > Signed-off-by: Bruce Allan > --- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 15 +++++++++++++-- > drivers/net/ethernet/intel/ice/ice_lib.c | 19 ------------------- > drivers/net/ethernet/intel/ice/ice_lib.h | 2 -- > drivers/net/ethernet/intel/ice/ice_main.c | 5 ----- > 4 files changed, 13 insertions(+), 28 deletions(-) Tested-by: Andrew Bowers