From: Vasily Averin <vvs@virtuozzo.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock
Date: Tue, 07 Jul 2015 20:53:19 +0300 [thread overview]
Message-ID: <559C120F.7020709@virtuozzo.com> (raw)
In-Reply-To: <CAM_iQpX=_chUgfy39ifgKkygYKVnh-r9WXK4P6q70xR_Oczv=g@mail.gmail.com>
On 07.07.2015 20:30, Cong Wang wrote:
> On Tue, Jul 7, 2015 at 10:25 AM, Vasily Averin <vvs@virtuozzo.com> wrote:
>> On 07.07.2015 20:13, Cong Wang wrote:
>>> On Tue, Jul 7, 2015 at 8:53 AM, Vasily Averin <vvs@virtuozzo.com> wrote:
>>>> ipmr_free_table() calls unregister_netdevice_many() inside
>>>> and changes net_todo_list protected by rtnl_lock
>>>
>>> Did you see any real bug?
>>
>> No, it was result of manual code review.
>>
>>> ipmr_free_table() is called in failure path, in this case there is no
>>> device registered yet, so unregister should be just a nop?
>>
>> However may be it's better to mark this place for future anyway?
>
> Then add a comment there. ;)
As you can see I'm not familiar with this code,
so I would like to ask you to do it. :)
prev parent reply other threads:[~2015-07-07 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 15:53 [Intel-wired-lan] [PATCH 3/3] ipmr_free_table() should be called under taken rtnl_lock Vasily Averin
2015-07-07 17:13 ` Cong Wang
2015-07-07 17:25 ` Vasily Averin
2015-07-07 17:30 ` Cong Wang
2015-07-07 17:53 ` Vasily Averin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559C120F.7020709@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox