Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH next 3/4] ixgbe: Enable TSO for stacked vlan
Date: Fri, 7 Aug 2015 15:22:23 +0900	[thread overview]
Message-ID: <55C44E9F.9010202@lab.ntt.co.jp> (raw)
In-Reply-To: <1438927643.2990.2.camel@intel.com>

On 2015/08/07 15:07, Jeff Kirsher wrote:
> On Thu, 2015-08-06 at 17:57 +0900, Toshiaki Makita wrote:
>> Setting ndo_features_check to passthru_features_check allows the
>> driver
>> to skip the check for multiple tagged TSO packets and enables stacked
>> vlan TSO.
>> Tested with 82599ES.
>>
>> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
>> ---
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> NACK!
> 
> This does not apply cleanly AND the ixgbe code already has
> a .ndo_features_check which is assigned to our ixgbe_features_check().
> 
> PLEASE pull my tree to ensure you are using the latest code when
> generating patches.

Oops...
I tested patches on next-queue's "master" branch but I now realize I
should have tested on "dev-queue" branch..

I'm sorry, this patch is completely unnecessary since
ixgbe_features_check() doesn't call vlan_check_features().

Toshiaki Makita


  reply	other threads:[~2015-08-07  6:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06  8:57 [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable TSO for stacked vlan Toshiaki Makita
2015-08-06  8:57 ` [Intel-wired-lan] [PATCH next 2/4] e1000e: " Toshiaki Makita
2015-08-21 22:32   ` Brown, Aaron F
2015-08-06  8:57 ` [Intel-wired-lan] [PATCH next 3/4] ixgbe: " Toshiaki Makita
2015-08-07  6:07   ` Jeff Kirsher
2015-08-07  6:22     ` Toshiaki Makita [this message]
2015-08-06  8:57 ` [Intel-wired-lan] [PATCH next 4/4] ixgbevf: Enables " Toshiaki Makita
2015-08-21 22:33 ` [Intel-wired-lan] [PATCH next 1/4] igbvf: Enable " Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C44E9F.9010202@lab.ntt.co.jp \
    --to=makita.toshiaki@lab.ntt.co.jp \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox