From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Date: Mon, 13 Jun 2016 21:14:41 +0200 Subject: [Intel-wired-lan] [net-next PATCH 04/15] bnxt: Replace ndo_add/del_vxlan_port with ndo_add/del_udp_enc_port In-Reply-To: References: <20160613173750.15186.24381.stgit@localhost.localdomain> <20160613174822.15186.55819.stgit@localhost.localdomain> Message-ID: <55c86ee3-4974-147e-c09a-a88f202fc3c4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 13.06.2016 20:41, Jesse Gross wrote: > On Mon, Jun 13, 2016 at 10:48 AM, Alexander Duyck wrote: >> This change replaces the network device operations for adding or removing a >> VXLAN port with operations that are more generically defined to be used for >> any UDP offload port but provide a type. As such by just adding a line to >> verify that the offload type if VXLAN we can maintain the same >> functionality. >> >> Signed-off-by: Alexander Duyck > > It looks like bnxt actually has a hardcoded offload of the Geneve port > rather than using the registration (maybe it predated it?). It would > be nice to incorporate that into your unified handler as well. > > I think you could actually just kill all of these > CONFIG_VXLAN/CONFIG_GENEVE checks (across all the drivers, not just > this one). They shouldn't be necessary any more now that there's no > longer strong linkage to the tunnel drivers. Yes, agreed. We can remove the CONFIG_VXLAN and CONFIG_GENEVE stuff now. But I think this can be a separate series. Bye, Hannes