From: Singhai, Anjali <anjali.singhai@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH v2 08/15] i40e/i40evf: Do not write to descriptor unless we complete
Date: Fri, 22 Jan 2016 13:23:51 -0800 [thread overview]
Message-ID: <56A29DE7.80707@intel.com> (raw)
In-Reply-To: <20160122002746.18278.34462.stgit@localhost.localdomain>
On 1/21/2016 4:27 PM, Alexander Duyck wrote:
> __be16 frag_off;
> u8 l4_proto = 0;
>
> ip.hdr = skb_network_header(skb);
> l4.hdr = skb_transport_header(skb);
>
> + /* words in MACLEN + dwords in IPLEN + dwords in L4Len */
May be the comment should say words in MACLEN and as the other fields
get added later, build upon it...
> + offset = ((ip.hdr - skb->data) / 2) <<
> + I40E_TX_DESC_LENGTH_MACLEN_SHIFT;
> +
>
> exthdr = ip.hdr + sizeof(*ip.v6);
> l4_proto = ip.v6->nexthdr;
> @@ -2487,34 +2492,33 @@ static void i40e_tx_enable_csum(struct sk_buff *skb, u32 *tx_flags,
> }
>
> /* Now set the td_offset for IP header length */
Comment needs to be fixed
> - *td_offset = ((l4.hdr - ip.hdr) / 4) << I40E_TX_DESC_LENGTH_IPLEN_SHIFT;
> - /* words in MACLEN + dwords in IPLEN + dwords in L4Len */
> - *td_offset |= (skb_network_offset(skb) >> 1) <<
> - I40E_TX_DESC_LENGTH_MACLEN_SHIFT;
> + offset |= ((l4.hdr - ip.hdr) / 4) << I40E_TX_DESC_LENGTH_IPLEN_SHIFT;
>
>
next prev parent reply other threads:[~2016-01-22 21:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 0:26 [Intel-wired-lan] [next PATCH v2 00/15] TSO and checksum fixes for i40e Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 01/15] i40e/i40evf: Drop outer checksum offload that was not requested Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 02/15] i40e/i40evf: Use u64 values instead of casting them in TSO function Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 03/15] i40e/i40evf: Factor out L4 header and checksum from L3 bits in TSO path Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 04/15] i40e/i40evf: Consolidate all header changes into TSO function Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 05/15] i40e/i40evf: Replace header pointers with unions of pointers in Tx checksum path Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 06/15] i40e/i40evf: Add support for IPv4 encapsulated in IPv6 Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 07/15] i40e/i40evf: Handle IPv6 extension headers in checksum offload Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 08/15] i40e/i40evf: Do not write to descriptor unless we complete Alexander Duyck
2016-01-22 21:23 ` Singhai, Anjali [this message]
2016-01-22 21:26 ` Alexander Duyck
2016-01-22 21:28 ` Singhai, Anjali
2016-01-22 21:37 ` Alexander Duyck
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 09/15] i40e/i40evf: Add exception handling for Tx checksum Alexander Duyck
2016-01-22 21:25 ` Singhai, Anjali
2016-01-22 0:27 ` [Intel-wired-lan] [next PATCH v2 10/15] i40e/i40evf: Clean-up Rx packet checksum handling Alexander Duyck
2016-01-22 0:28 ` [Intel-wired-lan] [next PATCH v2 11/15] i40e/i40evf: Enable support for SKB_GSO_UDP_TUNNEL_CSUM Alexander Duyck
2016-01-22 0:28 ` [Intel-wired-lan] [next PATCH v2 12/15] i40e: Fix ATR in relation to tunnels Alexander Duyck
2016-01-22 21:17 ` Singhai, Anjali
2016-01-22 0:28 ` [Intel-wired-lan] [next PATCH v2 13/15] i40e: Do not drop support for IPv6 VXLAN or GENEVE tunnels Alexander Duyck
2016-01-22 0:28 ` [Intel-wired-lan] [next PATCH v2 14/15] i40e: Update feature flags to reflect newly enabled features Alexander Duyck
2016-01-22 21:15 ` Singhai, Anjali
2016-01-22 21:34 ` Alexander Duyck
2016-01-22 0:28 ` [Intel-wired-lan] [next PATCH v2 15/15] i40evf: " Alexander Duyck
2016-01-22 21:27 ` Singhai, Anjali
2016-01-22 21:36 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A29DE7.80707@intel.com \
--to=anjali.singhai@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox