Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 net-next 2/3] net: ixgbe: Fix cls_u32 offload support for fields with masks.
Date: Mon, 07 Mar 2016 11:30:25 -0800	[thread overview]
Message-ID: <56DDD6D1.3030501@gmail.com> (raw)
In-Reply-To: <1457372509-3135-2-git-send-email-sridhar.samudrala@intel.com>

On 16-03-07 09:41 AM, Sridhar Samudrala wrote:
> Remove the incorrect check for mask in ixgbe_configure_clsu32 and
> drop the 'mask' field that is not required in struct ixgbe_mat_field
> 
> Verified with the following filters:
> 
>  #tc qdisc add dev p4p1 ingress
>  #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> 	handle 800:0:1 u32 ht 800: \
> 	match ip dst 10.0.0.1/8 match ip src 10.0.0.2/8 action drop
>  #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> 	handle 800:0:2 u32 ht 800: \
> 	match ip dst 11.0.0.1/16 match ip src 11.0.0.2/16 action drop
>  #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> 	handle 800:0:3 u32 ht 800: \
> 	match ip dst 12.0.0.1/24 match ip src 12.0.0.2/24 action drop
>  #tc filter add dev p4p1 parent ffff: protocol ip prio 99 \
> 	handle 800:0:4 u32 ht 800: \
> 	match ip dst 13.0.0.1/32 match ip src 13.0.0.2/32 action drop
> 
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> ---


Nice cleanup now we can support various masks as well on the other
fields.

Acked-by: John Fastabend <john.r.fastabend@intel.com>

  reply	other threads:[~2016-03-07 19:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 17:41 [Intel-wired-lan] [PATCH v2 net-next 1/3] net: ixgbe: fix error handling in tc cls_u32 offload routines Sridhar Samudrala
2016-03-07 17:41 ` [Intel-wired-lan] [PATCH v2 net-next 2/3] net: ixgbe: Fix cls_u32 offload support for fields with masks Sridhar Samudrala
2016-03-07 19:30   ` John Fastabend [this message]
2016-03-08 23:08   ` Bowers, AndrewX
2016-03-07 17:41 ` [Intel-wired-lan] [PATCH v2 net-next 3/3] net: ixgbe: Fix cls_u32 offload support for L4 ports Sridhar Samudrala
2016-03-07 19:31   ` John Fastabend
2016-03-07 19:29 ` [Intel-wired-lan] [PATCH v2 net-next 1/3] net: ixgbe: fix error handling in tc cls_u32 offload routines John Fastabend
2016-03-08 23:09 ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DDD6D1.3030501@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox