Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Samudrala, Sridhar <sridhar.samudrala@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix flag issue in generic CSUM patch
Date: Mon, 04 Apr 2016 16:25:30 -0700	[thread overview]
Message-ID: <5702F7EA.3050403@intel.com> (raw)
In-Reply-To: <20160404230235.14334.80472.stgit@localhost.localdomain>



On 4/4/2016 4:03 PM, Alexander Duyck wrote:
> This patch fixes a minor flags issue where we had lost NETIF_F_HW_TC and
> were setting NETIF_F_SCTP_CRC in two different spots when we only wanted to
> enable it in the if statement.
>
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Acked-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

> ---
>
> This should fix both the one issue I saw and the NETIF_F_HW_TC issue that
> Sridar saw with the generic CSUM patch.
>
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index 51ce426ce510..30903c5517af 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -9214,7 +9214,6 @@ skip_sriov:
>   			   NETIF_F_RXHASH |
>   			   NETIF_F_RXCSUM |
>   			   NETIF_F_HW_CSUM |
> -			   NETIF_F_SCTP_CRC |
>   			   NETIF_F_HW_VLAN_CTAG_TX |
>   			   NETIF_F_HW_VLAN_CTAG_RX |
>   			   NETIF_F_HW_VLAN_CTAG_FILTER;
> @@ -9228,7 +9227,8 @@ skip_sriov:
>   			       NETIF_F_HW_L2FW_DOFFLOAD;
>   
>   	if (hw->mac.type >= ixgbe_mac_82599EB)
> -		netdev->hw_features |= NETIF_F_NTUPLE;
> +		netdev->hw_features |= NETIF_F_NTUPLE |
> +				       NETIF_F_HW_TC;
>   
>   	netdev->vlan_features |= NETIF_F_SG |
>   				 NETIF_F_TSO |
>


      reply	other threads:[~2016-04-04 23:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 23:03 [Intel-wired-lan] [PATCH] ixgbe: Fix flag issue in generic CSUM patch Alexander Duyck
2016-04-04 23:25 ` Samudrala, Sridhar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5702F7EA.3050403@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox