From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH -next] intel: Simplify bool conversion
Date: Wed, 29 Sep 2021 16:12:19 +0000 [thread overview]
Message-ID: <572f388c1678cbd8354f8788fbb0243396ec76d9.camel@intel.com> (raw)
In-Reply-To: <1632898586-96655-1-git-send-email-yang.lee@linux.alibaba.com>
On Wed, 2021-09-29 at 14:56 +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/net/ethernet/intel/i40e/i40e_xsk.c:229:35-40: WARNING:
> conversion to bool not needed here
> ./drivers/net/ethernet/intel/ice/ice_xsk.c:399:35-40: WARNING:
> conversion to bool not needed here
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Tony Nguyen <anthony.l.nguyen@intel.com>
This applies to patches that went through BPF[1] and aren't on the
Intel wired LAN yet. BPF - did you want to pick this up?
[1]
https://patchwork.kernel.org/project/netdevbpf/list/?series=550775&stat
e=*
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 6f85879..ea06e95 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -226,7 +226,7 @@ bool i40e_alloc_rx_buffers_zc(struct i40e_ring
> *rx_ring, u16 count)
> rx_desc->wb.qword1.status_error_len = 0;
> i40e_release_rx_desc(rx_ring, ntu);
>
> - return count == nb_buffs ? true : false;
> + return count == nb_buffs;
> }
>
> /**
> diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c
> b/drivers/net/ethernet/intel/ice/ice_xsk.c
> index 7682eaa..35b6e81 100644
> --- a/drivers/net/ethernet/intel/ice/ice_xsk.c
> +++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
> @@ -396,7 +396,7 @@ bool ice_alloc_rx_bufs_zc(struct ice_ring
> *rx_ring, u16 count)
> rx_desc->wb.status_error0 = 0;
> ice_release_rx_desc(rx_ring, ntu);
>
> - return count == nb_buffs ? true : false;
> + return count == nb_buffs;
> }
>
> /**
next prev parent reply other threads:[~2021-09-29 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 6:56 [Intel-wired-lan] [PATCH -next] intel: Simplify bool conversion Yang Li
2021-09-29 16:12 ` Nguyen, Anthony L [this message]
2021-10-25 18:37 ` Brelinski, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572f388c1678cbd8354f8788fbb0243396ec76d9.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox