Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change I219 (19) devices to ADP

["Lifshits, Vitaly" <vitaly.lifshits@intel.com>]

Dear Paul,

On 8/15/2024 5:16 PM, Paul Menzel wrote:
> Dear Vitaly,
> 
> 
> Thank you for the patch.
> 
> 
> Am 15.08.24 um 15:11 schrieb Vitaly Lifshits:
>> Change the MAC and board types of I219 (19) devices from MTP to ADP.
>> These devices have hardware more closely related to ADP than MTP.
> 
> According to what metric are they more similar to ADP?
> 
> Do you have any bug reports or test system with problems?
> 
>> Fixes: db2d737d63c5 ("e1000e: Separate MTP board type from ADP")
> 
> So, it’s present since v6.2-rc1 from December 2022. Why change it now?

The device IDs affected by this patch have not been released to the
public yet. It was found during an internal review that the appropriate 
board type is ADP, not MTP.

> 
> 
> Kind regards,
> 
> Paul
> 
> 
>> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/hw.h     | 4 ++--
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ 
>> ethernet/intel/e1000e/hw.h
>> index 4b6e7536170a..fc8ed38aa095 100644
>> --- a/drivers/net/ethernet/intel/e1000e/hw.h
>> +++ b/drivers/net/ethernet/intel/e1000e/hw.h
>> @@ -108,8 +108,8 @@ struct e1000_hw;
>>   #define E1000_DEV_ID_PCH_RPL_I219_V22        0x0DC8
>>   #define E1000_DEV_ID_PCH_MTP_I219_LM18        0x550A
>>   #define E1000_DEV_ID_PCH_MTP_I219_V18        0x550B
>> -#define E1000_DEV_ID_PCH_MTP_I219_LM19        0x550C
>> -#define E1000_DEV_ID_PCH_MTP_I219_V19        0x550D
>> +#define E1000_DEV_ID_PCH_ADP_I219_LM19        0x550C
>> +#define E1000_DEV_ID_PCH_ADP_I219_V19        0x550D
>>   #define E1000_DEV_ID_PCH_LNP_I219_LM20        0x550E
>>   #define E1000_DEV_ID_PCH_LNP_I219_V20        0x550F
>>   #define E1000_DEV_ID_PCH_LNP_I219_LM21        0x5510
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ 
>> ethernet/intel/e1000e/netdev.c
>> index 360ee26557f7..80f8e23bc4f5 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -7896,10 +7896,10 @@ static const struct pci_device_id 
>> e1000_pci_tbl[] = {
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_V17), 
>> board_pch_adp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_RPL_I219_LM22), 
>> board_pch_adp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_RPL_I219_V22), 
>> board_pch_adp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_LM19), 
>> board_pch_adp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ADP_I219_V19), 
>> board_pch_adp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_MTP_I219_LM18), 
>> board_pch_mtp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_MTP_I219_V18), 
>> board_pch_mtp },
>> -    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_MTP_I219_LM19), 
>> board_pch_mtp },
>> -    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_MTP_I219_V19), 
>> board_pch_mtp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_LNP_I219_LM20), 
>> board_pch_mtp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_LNP_I219_V20), 
>> board_pch_mtp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_LNP_I219_LM21), 
>> board_pch_mtp },
>