From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>
Cc: Wojciech Drewek <wojciech.drewek@intel.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Michal Kubiak <michal.kubiak@intel.com>,
intel-wired-lan@lists.osuosl.org,
Amritha Nambiar <amritha.nambiar@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
bpf@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
magnus.karlsson@intel.com,
Chandan Kumar Rout <chandanx.rout@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 1/6] ice: move netif_queue_set_napi to rtnl-protected sections
Date: Wed, 21 Aug 2024 14:20:34 -0700 [thread overview]
Message-ID: <599caa46-3723-1a54-8122-90474bfccfe1@intel.com> (raw)
In-Reply-To: <ZsSZnLt9k7zn8G6T@boxer>
On 8/20/2024 6:26 AM, Maciej Fijalkowski wrote:
...
>>>> Fixes: 080b0c8d6d26 ("ice: Fix ASSERT_RTNL() warning during certain scenarios")
>>>
>>> Shouldn't you include:
>>> Fixes: 91fdbce7e8d6 ("ice: Add support in the driver for associating queue with napi")
>>>
>>> as we were iterating over XDP rings that were attached to q_vectors from
>>> the very beginning?
>>>
>>
>> I probably should have done this.
>
> Maybe this could be included while applying or sending the pull request by
> Tony. I'll go through the rest of set today to see if I have any comments,
> if there won't be anything outstanding then it won't make sense to send
> next revision just to fix the fixes tags.
Yes, I can add that in.
Thanks,
Tony
next prev parent reply other threads:[~2024-08-21 21:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 10:05 [Intel-wired-lan] [PATCH iwl-net v3 0/6] ice: fix synchronization between .ndo_bpf() and reset Larysa Zaremba
2024-08-19 10:05 ` [Intel-wired-lan] [PATCH iwl-net v3 1/6] ice: move netif_queue_set_napi to rtnl-protected sections Larysa Zaremba
2024-08-20 12:31 ` Maciej Fijalkowski
2024-08-20 12:47 ` Larysa Zaremba
2024-08-20 13:26 ` Maciej Fijalkowski
2024-08-21 21:20 ` Tony Nguyen [this message]
2024-08-19 10:05 ` [Intel-wired-lan] [PATCH iwl-net v3 2/6] ice: protect XDP configuration with a mutex Larysa Zaremba
2024-08-22 11:39 ` Maciej Fijalkowski
2024-08-22 13:05 ` Larysa Zaremba
2024-08-19 10:05 ` [Intel-wired-lan] [PATCH iwl-net v3 3/6] ice: check for XDP rings instead of bpf program when unconfiguring Larysa Zaremba
2024-08-22 11:36 ` Maciej Fijalkowski
2024-08-19 10:05 ` [Intel-wired-lan] [PATCH iwl-net v3 4/6] ice: check ICE_VSI_DOWN under rtnl_lock when preparing for reset Larysa Zaremba
2024-08-22 11:34 ` Maciej Fijalkowski
2024-08-22 12:56 ` Larysa Zaremba
2024-08-22 14:42 ` Maciej Fijalkowski
2024-08-22 17:18 ` Larysa Zaremba
2024-08-19 10:05 ` [Intel-wired-lan] [PATCH iwl-net v3 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code Larysa Zaremba
2024-08-22 11:43 ` Maciej Fijalkowski
2024-08-22 13:07 ` Larysa Zaremba
2024-08-19 10:05 ` [Intel-wired-lan] [PATCH iwl-net v3 6/6] ice: do not bring the VSI up, if it was down before the XDP setup Larysa Zaremba
2024-08-22 11:35 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599caa46-3723-1a54-8122-90474bfccfe1@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chandanx.rout@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox