From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Karol Kolacinski <karol.kolacinski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: netdev@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/5] ice: Fix E825 initialization
Date: Wed, 2 Oct 2024 15:00:26 -0700 [thread overview]
Message-ID: <5c0d64bd-3730-c0e7-b0af-5929aa4fbf9d@intel.com> (raw)
In-Reply-To: <20240930121022.671217-2-karol.kolacinski@intel.com>
On 9/30/2024 5:08 AM, Karol Kolacinski wrote:
> Current implementation checks revision of all PHYs on all PFs, which is
> incorrect and may result in initialization failure. Check only the
> revision of the current PHY.
This patch seems to be doing too many things. This part sounds like a patch.
> E825 does not need to modify sideband queue access, because those values
> are properly set by the firmware on init.
> Remove PF_SB_REM_DEV_CTL modification.
This seems like another patch. Also, this doesn't sound like a bug so it
should go via -next.
> Configure synchronization delay for E825 product to ensure proper PHY
> timers initialization on SYNC command.
This sounds like another patch.
Thanks,
Tony
next prev parent reply other threads:[~2024-10-02 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 12:08 [Intel-wired-lan] [PATCH iwl-net 0/5] Fix E825 initialization Karol Kolacinski
2024-09-30 12:08 ` [Intel-wired-lan] [PATCH iwl-net 1/5] ice: " Karol Kolacinski
2024-10-02 22:00 ` Tony Nguyen [this message]
2024-09-30 12:08 ` [Intel-wired-lan] [PATCH iwl-net 2/5] ice: Fix quad registers read on E825 Karol Kolacinski
2024-10-02 22:08 ` Tony Nguyen
2024-09-30 12:08 ` [Intel-wired-lan] [PATCH iwl-net 3/5] ice: Fix ETH56G FC-FEC Rx offset value Karol Kolacinski
2024-09-30 12:08 ` [Intel-wired-lan] [PATCH iwl-net 4/5] ice: Remove unnecessary offset calculation for PF scoped registers Karol Kolacinski
2024-10-02 22:12 ` Tony Nguyen
2024-09-30 12:08 ` [Intel-wired-lan] [PATCH iwl-net 5/5] ice: Add correct PHY lane assignment Karol Kolacinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0d64bd-3730-c0e7-b0af-5929aa4fbf9d@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox