From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB184C3271E for ; Fri, 5 Jul 2024 16:58:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 655EC4023C; Fri, 5 Jul 2024 16:58:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WvWfejCsTEXp; Fri, 5 Jul 2024 16:58:49 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 70AAD4023D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1720198729; bh=53IWNUqv/dAAWYlqkFKigcK2SNfNDfaWpHcnGTZ50h4=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=24Z6PjOuhdlW3H/AYd3q97dKq5FLqu9T1xOofBnND79SCO9GIDmAcNWkGECOnpJOE /v94Irz8WF9f1GWlBau24Ef3erdCY/mWNmMwmtO6tVpI2cua4kyqiIUFPCH4A5dolM FlvbP0IptVSJx7ymGN3MmFQ18on7Te5lnY+w6UJtHtSi/5x559t9spurnKaw7/KqHN Hm5Yp/9xtJ3qDl0zH+KrICo6e92xNDuGrcW5AlyiygvF8XambdZiPitHh/xi/8vlXg nGmRWBNuT8426HXz6wZ47bOM63Fl6q2ifxdVnLHmuhYpBQu8+NTaL9bOJyl+fuAOOl KcQ0ACTlYTHyw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 70AAD4023D; Fri, 5 Jul 2024 16:58:49 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 702C01BF281 for ; Fri, 5 Jul 2024 16:58:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 699236062D for ; Fri, 5 Jul 2024 16:58:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WfYvvIunHfij for ; Fri, 5 Jul 2024 16:58:47 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.13; helo=mgamail.intel.com; envelope-from=faizal.abdul.rahim@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 929F460612 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 929F460612 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by smtp3.osuosl.org (Postfix) with ESMTPS id 929F460612 for ; Fri, 5 Jul 2024 16:58:47 +0000 (UTC) X-CSE-ConnectionGUID: mI0qtLjIQ1+M9qo4NtIm+Q== X-CSE-MsgGUID: tpkln+ZKT2ye/VNiHCMnZA== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="28649325" X-IronPort-AV: E=Sophos;i="6.09,185,1716274800"; d="scan'208";a="28649325" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2024 09:58:46 -0700 X-CSE-ConnectionGUID: TFZusHLnTp+7M7CpwAdY1w== X-CSE-MsgGUID: XPBUW+DgTyi4UrXnOfwS9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,185,1716274800"; d="scan'208";a="51518219" Received: from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.38.162]) ([10.247.38.162]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2024 09:58:43 -0700 Message-ID: <5dbb95b5-96c1-4bbc-a4e0-c0616efa7ac2@linux.intel.com> Date: Sat, 6 Jul 2024 00:58:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Simon Horman References: <20240702040926.3327530-1-faizal.abdul.rahim@linux.intel.com> <20240702040926.3327530-2-faizal.abdul.rahim@linux.intel.com> <20240703150830.GO598357@kernel.org> Content-Language: en-US From: "Abdul Rahim, Faizal" In-Reply-To: <20240703150830.GO598357@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720198727; x=1751734727; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oOHv5vKH1IZynVlCLLK+KNAq96qbLhSgisVIUWyYrEw=; b=LglkokbFeKZDd1CrkI9XuvBc079rCovaDgiABCmfugHQQR4qOv4KczjX kvTFsz6eA7oKgrEcfuJrhv2M2MEPTnIZLm1C1mql+mkDQo4R+FSkDOSe+ q3KilVjPlK9JIneSpdxlYq5a2y1GHvw45AwcM9Bsn1MBSNzbBWOUJZmpz 99pj4l7g/lNcCwirWpaEGXajTVOI25TdTlICYCGUy/SGZXZbgRxnmQEhF R+pF5/dcqJ6k2ktxHDx8VDB9wbx/muNAk9w2x8VcPDmil9RyHpdHVl2Wt KFqlvLFbs48tgjuG4nTUTRcAnf8cr5OTBOB9UmyTtwTye3wyUiYWttlMw g==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=LglkokbF Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1 1/4] igc: Fix qbv_config_change_errors logics X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, richardcochran@gmail.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" >> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c >> index 22cefb1eeedf..02dd41aff634 100644 >> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c >> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c >> @@ -78,6 +78,17 @@ void igc_tsn_adjust_txtime_offset(struct igc_adapter *adapter) >> wr32(IGC_GTXOFFSET, txoffset); >> } >> >> +bool igc_tsn_is_taprio_activated_by_user(struct igc_adapter *adapter) >> +{ >> + struct igc_hw *hw = &adapter->hw; >> + >> + if ((rd32(IGC_BASET_H) || rd32(IGC_BASET_L)) && >> + adapter->taprio_offload_enable) >> + return true; >> + else >> + return false; > > As per my response to patch 2/4, I think something like this is a bit > nicer: > > (Completely untested!) > > return (rd32(IGC_BASET_H) || rd32(IGC_BASET_L)) && > adapter->taprio_offload_enable; > > Will update, thanks.