From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bowers, AndrewX Date: Fri, 1 Nov 2019 16:45:27 +0000 Subject: [Intel-wired-lan] [PATCH S32 14/15] ice: use more accurate ICE_DBG mask types In-Reply-To: <20191025143441.50151-14-anthony.l.nguyen@intel.com> References: <20191025143441.50151-1-anthony.l.nguyen@intel.com> <20191025143441.50151-14-anthony.l.nguyen@intel.com> Message-ID: <5ef2631aeb86434abf635807911214f2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On > Behalf Of Tony Nguyen > Sent: Friday, October 25, 2019 7:35 AM > To: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH S32 14/15] ice: use more accurate ICE_DBG > mask types > > From: Jacob Keller > > ice_debug_cq is passed a mask which is always ICE_DBG_AQ_CMD. Modify > this function, removing the mask parameter entirely, and directly use the > more appropriate ICE_DBG_AQ_DESC and ICE_DBG_AQ_DESC_BUF. > > The function is only called from ice_controlq.c, and has no other callers > outside of that file. Move it and mark it static to avoid namespace pollution. > > Signed-off-by: Jacob Keller > Signed-off-by: Tony Nguyen > --- > drivers/net/ethernet/intel/ice/ice_common.c | 50 ---------------- > drivers/net/ethernet/intel/ice/ice_common.h | 2 - > drivers/net/ethernet/intel/ice/ice_controlq.c | 57 +++++++++++++++++-- > drivers/net/ethernet/intel/ice/ice_type.h | 2 + > 4 files changed, 53 insertions(+), 58 deletions(-) Tested-by: Andrew Bowers